347232 - Cosmetic issues with new download dialog

Status: NEW

(Firefox :: File Handling, defect)

Description

[:deanis74]

See attachment "FileOpen.png".

1. "which is a" and "from" labels are not vertically-aligned with the data beside them.
2. Do we need the colon after "which is a"?  It would read smoother if it wasn't there.  Then we could just make it one label.
3. Lots of grey space on the right side of the dialog.
4. Lots of grey space between the labels and the buttons.

Comment 1

[:deanis74]

Attachment: OpenFile.png

Comment 2

[Michael Wu [:mwu]]

You may wish to update your screenshot with the downlaod dialog in a more recent build. (See bug 344984)

Comment 3

[:deanis74]

(In reply to comment #2)
> You may wish to update your screenshot with the downlaod dialog in a more
> recent build. (See bug 344984)

It still has the same issues, just that items 1 and 2 are shifted slightly to the right.

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 347803 has been marked as a duplicate of this bug. ***

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: save-file dialog w/ extension hook-in

The fix for this bug should make it so that extensions who add themselves to this dialog don't look ugly and out-of-place (see screenshot). Ideally, we should expose a single point at which extensions can hook in to the dialog, which displays them in both.

Comment 6

[Filippo]

(In reply to comment #0)
> See attachment "FileOpen.png".
> 
> 1. "which is a" and "from" labels are not vertically-aligned with the data
> beside them.
> 2. Do we need the colon after "which is a"?  It would read smoother if it
> wasn't there.  Then we could just make it one label.
> 3. Lots of grey space on the right side of the dialog.
> 4. Lots of grey space between the labels and the buttons.
> 

In answer to the point 2 question, we need the semicolon for Italian versions, because the phrase "which is a" should have a different form if the file type word is a male gender word or a female gender word. By using the semicolon, the phrase can be the same for both genders.

Comment 7

[:deanis74]

(In reply to comment #6)
> 
> In answer to the point 2 question, we need the semicolon for Italian versions,
> because the phrase "which is a" should have a different form if the file type
> word is a male gender word or a female gender word. By using the semicolon, the
> phrase can be the same for both genders.

Something like that could go in the Italian translation specifically (and other languages that need it).

Comment 8

[:Gavin Sharp [email: [e-mail]]]

*** Bug 353561 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Cowperthwaite]

The phrase "which is a XXXXX" has the potential to be misleading.  The whole reason this dialog is displayed is because the file has been served up as application/octet-stream -- therefore, per Mozilla at least, not necessarily what it claims to be, which is why we're not handling it like the file type claimed by the extension.

How the extension<=>type mapping works under Mac or Linux or any other 
non-Windows platform is unknown to me, but presumably it's there, since this dialog is making the effort.

I'm afraid I can't come up with a terse, cogent phrase explaining the situation that would fit on a dialog, particularly if we're continuing to shield ignorant users from the concept of a MIME type.  The best I can conceive of: 

  The ".JPG" extension means this probably is an "Image file"
       ^^^^ from the file                         ^^^^^^^^^^ from the registry

If the file extension is not registered:

  The ".BAZ" extension is unknown


See also bug 293804 comment 6, about a similar issue with non-generic but unknown MIME types.