347523 - nsXBLBinding should use importNode instead of cloneNode

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Peter Van der Beken [:peterv]]

since it's moving the cloned nodes into a new document.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Peter Van der Beken [:peterv]]

I had to back this out because the tree went orange. The problem is the security check in ImportNode fails (XBL node coming from a chrome binding, the document imported into being a content document). I could probably use the nsNodeUtils::Clone function that I added in my patch for bug 347524 instead, which doesn't have the security check.

Comment 3

[Sergei Dolgov]

Peter, maybe you can share some wisdom on bug
https://bugzilla.mozilla.org/show_bug.cgi?id=349526
?
Since mid of August, 2006, we are getting permanent crashes in BeOS port  with various stack crawls, but those all have one common thing - calling
nsXBLService::LoadBindings() and then crashing few steps later with segment violation,
in UUID Generator or in GetFactory

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v2

This one works better (it doesn't do the security check, which is what we want, right?).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 237716 [details] [diff] [review]
v2

Nice!  r+sr=bzbarsky

Comment 6

[Peter Van der Beken [:peterv]]

Tree stayed green this time.

Comment 7

[Brendan Eich [:brendan]]

This fix exposed bug 347523.

/be

Comment 8

[Brendan Eich [:brendan]]

(In reply to comment #7)
> This fix exposed bug 347523.

Er, bug 355811.

/be