Closed Bug 347539 Opened 18 years ago Closed 18 years ago

Missing accesskeys in font pref panel

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Thunderbird2.0

People

(Reporter: cedric.corazza, Assigned: cedric.corazza)

Details

(Keywords: access, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Patch addressing comment #2
2.05 KB, patch
mscott
: review+
mscott
: approval-thunderbird2+
Details | Diff | Splinter Review 
There are two missing accesskeys for "Size (pixels)" in Edition > Preferences > Display > Fonts tab > Fonts... button.
I think there should be ones, as it is the case for Firefox for the same panel.
Patch follows

        Attachment #232341 -
        Flags: review?(mscott)

        Attachment #232341 -
        Flags: approval-thunderbird2?

    
    

    
  
Comment on attachment 232341 [details] [diff] [review]
Patch adding accesskeys for "Size (pixels)" labels

Thanks for the patch cedric. How about re-naming the access keys to be more specific. Instead of size1.accessey and size2.accesskey make it something like

proportionalSize.accesskey
and
monospaceSize.accesskey

I'll plus the patch if you make that change for me. Thanks!

        Attachment #232341 -
        Flags: review?(mscott)

        Attachment #232341 -
        Flags: review-

        Attachment #232341 -
        Flags: approval-thunderbird2?

    
    

    
  
No problem. Will do this tomorrow. I just reproduced the pattern used for Firefox.

    
    

    
  


  

        Attachment #232341 -
        Attachment is obsolete: true

        Attachment #232682 -
        Flags: review?(mscott)

    
    

    
  
Comment on attachment 232682 [details] [diff] [review]
Patch addressing comment #2

awesome, thanks a lot for fixing that.

        Attachment #232682 -
        Flags: review?(mscott)

        Attachment #232682 -
        Flags: review+

        Attachment #232682 -
        Flags: approval-thunderbird2+

    
    

    
  
Note the related patch at bug 347519.
Severity: normal → trivial
OS: Linux → All
Hardware: PC → All
Version: unspecified → 1.5

    
  
Whiteboard: [checkin-needed]

    
    

    
  
Hi,
Could someone check this in please as this bug got all the needed approvals?
Thanks

    
  
Whiteboard: [checkin-needed] → [checkin needed]
Assignee: mscott → cedric.corazza

    
    

    
  
mozilla/mail/components/preferences/fonts.xul 	1.9
mozilla/mail/locales/en-US/chrome/messenger/preferences/fonts.dtd 	1.6
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [checkin needed (1.8 branch)]

    
    

    
  
mozilla/mail/locales/en-US/chrome/messenger/preferences/fonts.dtd 	1.3.2.3
mozilla/mail/components/preferences/fonts.xul 	1.4.2.5
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: --- → Thunderbird2.0

    
    

    
  
V with TB 2b1-1018, Win2K.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: