Closed
Bug 347583
Opened 18 years ago
Closed 18 years ago
Theme preview on Linux has incorrect background color and mgr. lists don't have borders
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
(Keywords: fixed1.8.1, polish)
Attachments
(3 files, 2 obsolete files)
65.19 KB,
image/png
|
Details | |
137.04 KB,
image/png
|
Details | |
2.59 KB,
patch
|
robert.strong.bugs
:
review+
dbaron
:
approval1.8.1+
|
Details | Diff | Splinter Review |
screenshots and patch coming up
Assignee | ||
Comment 1•18 years ago
|
||
Assignee | ||
Comment 2•18 years ago
|
||
Attachment #232392 -
Flags: review?(sspitzer)
Assignee | ||
Updated•18 years ago
|
Attachment #232392 -
Flags: review?(sspitzer) → review?(gavin.sharp)
Assignee | ||
Comment 3•18 years ago
|
||
This is essentially the same as bug 310113 except for the theme preview area
Comment 4•18 years ago
|
||
Comment on attachment 232392 [details] [diff] [review] patch r=me, but you may want to copy over some of the style rules from http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/winstripe/global/listbox.css&rev=1.9#47 too, to get a full "listbox" styling.
Attachment #232392 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 5•18 years ago
|
||
Assignee | ||
Comment 6•18 years ago
|
||
Attachment #232391 -
Attachment is obsolete: true
Assignee | ||
Comment 7•18 years ago
|
||
Attachment #232392 -
Attachment is obsolete: true
Assignee | ||
Comment 8•18 years ago
|
||
Comment on attachment 232468 [details] [diff] [review] patch - also fixes borders for linux (win32 looks the same) added border styling per comment #4. carrying forward r+
Attachment #232468 -
Flags: review+
Comment 9•18 years ago
|
||
Should the richlistbox rules be in xul.css?
Assignee | ||
Comment 10•18 years ago
|
||
I don't believe so. These are theme specific and it should be possible to over-ride them with the theme.
Assignee | ||
Comment 11•18 years ago
|
||
Also, -moz-appearance: listbox IMO should pick up the styling as it does for win32 but with 2.0 around the corner I don't have time to figure out why it doesn't.
Assignee | ||
Updated•18 years ago
|
Summary: Theme preview on Linux has incorrect background color → Theme preview on Linux has incorrect background color and mgr. lists don't have borders
Assignee | ||
Comment 12•18 years ago
|
||
Comment on attachment 232468 [details] [diff] [review] patch - also fixes borders for linux (win32 looks the same) simple polish fix to make the add-ons mgr. and xpinstall dialog look decent on linux.
Attachment #232468 -
Flags: approval1.8.1?
Comment 13•18 years ago
|
||
(In reply to comment #10) > I don't believe so. These are theme specific and it should be possible to > over-ride them with the theme. Duh, I meant toolkit/themes/winstripe/global/richlistbox.css, not xul.css.
Assignee | ||
Comment 14•18 years ago
|
||
I really could go either way on that since it appears that anything with -moz-appearance: listbox doesn't get styled with the background-color, color, or border as it does for win32.
Comment on attachment 232468 [details] [diff] [review] patch - also fixes borders for linux (win32 looks the same) a=dbaron on behalf of drivers. Please land on MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword once you have done so.
Attachment #232468 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 16•18 years ago
|
||
Checked in to MOZILLA_1_8_BRANCH
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•