347641 - highlight of selected images extends too much to the top and left

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Uri Bernstein]

When an image is selected, the highlighted rectangle is usually too large - extending to the left and top of the image. This happens in a non totally predictable way: the same image might have a different highlighted area depending (in a non-straightforward way) on its surroundings.  

This regressed between 2006-01-25 and 2006-01-26, likely due to bug 317375.

I'll attach a testcase immediately.

Comment 1

[Uri Bernstein]

Attachment: testcase

The margins on the images aren't necessary for the bug to show - they just help see what's going on by preventing the highlights from overlapping.

Comment 2

[Uri Bernstein]

Attachment: screenshot of testcase

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Are you going to fix this or am I? :-)

Comment 4

[Uri Bernstein]

(In reply to comment #3)
> Are you going to fix this or am I? :-)

Probably you, unless you give me some good hints where to start looking. I never dealt with highlighting code before.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That code is right here
http://lxr.mozilla.org/seamonkey/source/layout/generic/nsFrame.cpp#779

I'm always happy to give hints :-)

Comment 6

[Uri Bernstein]

This WFM since 2006-11-22, that is, since the switch to cairo (bug 323934).