347922 - Adding ATOM feed hangs forever for validation

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Dwaine Gonyier]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Thunderbird version 1.5.0.5 (20060719)

I attempted to add the following feed to Thunderbird
http://guildcast.com/show/?feed=atom
and the subscription window would stay in the validating feed state forever until I close it.

The following error shows up in the Javascript console:
Error: someHTML has no properties
Source File: chrome://messenger-newsblog/content/feed-parser.js
Line: 490


Reproducible: Always

Steps to Reproduce:
See details for basic procedure to reproduce

Actual Results:  
subscription manager is stuck in validating feed state

Expected Results:  
Feed subscription should succeed

This feed operates normally when added as a live bookmark in Firefox 1.5.0.6 for windows on the same PC.

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060809 Thunderbird/2.0a1 ID:2006080904

The error is from here:

  stripTags: function(someHTML) 
  {
    return someHTML.replace(/<[^>]+>/g,"");
  },

Comment 2

[Mike Cowperthwaite]

FWIW, the feed reports as Atom 0.3, which is no longer supported by feedvalidator.org or the W3C feed validator.

Comment 3

[Boris Kairat]

Same Problem.
Thunderbird subscription manager is stuck in validating feed state. TB1.5
Firefox is also not able to load the dynamic bookmark. FF1.5

Comment 4

[Dwaine Gonyier]

(In reply to comment #3)
> Same Problem.
> Thunderbird subscription manager is stuck in validating feed state. TB1.5
> Firefox is also not able to load the dynamic bookmark. FF1.5
> 

I still have this same problem with the same feed URL in Thunderbird 1.5.0.10
Firefox 1.5.0.11 has no problems with is feed and loads it just fine...

Comment 5

[Dwaine Gonyier]

Actually, the same site offers an alternative feed for the same information:

http://guildcast.com/show/?feed=rss2

Unfortunately, subscribing to this feed in Thunderbird also hangs forever and the folllowing javascript error is logged in Thunderbird:

Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetLiteral]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger-newsblog/content/Feed.js :: anonymous :: line 219"  data: no]
Source File: chrome://messenger-newsblog/content/Feed.js
Line: 219


Firefox 1.5.0.10 (note that my previous comment has a typo for the firefox version... should be 1.5.0.10 there as well) has no problems with this alternate feed.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Don't hang on verifying when the feed has a blank title element.

Comment 7

[Mike Cowperthwaite]

That patch is really for bug 332910, no?  Is the original Atom feed from comment 0 also failing because of a blank title?

Comment 8

[Magnus Melin [:mkmelin]]

Yeah, that sounds like a dupe... (or the other way around)
Both checks this patch adds are needed when title is blank.

Tried http://guildcast.com/show/?feed=rss2 and http://guildcast.com/show/?feed=atom

Comment 9

[Scott MacGregor]

Comment on attachment 257849 [details] [diff] [review]
proposed fix

I'm going to sneak this into tb2 as well since we haven't tagged yet.

Comment 10

[Scott MacGregor]

fixed

Comment 12

[Carsten Book [:Tomcat]]

Verified fixed for 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3 ID:2007030919 

Tested with the 2 Feeds from comment #8 

Feeds were added and working fine.

Comment 13

[Merike Sell (:merike)]

Both feeds from comment 8 don't work for me. Using Linux 2.0.0.14 (20080502) version on Kubuntu. Could somebody try it with Thunderbird NOT from Ubuntu package but from source to find out if it is due to the way it is packaged for Ubuntu?

Comment 14

[Merike Sell (:merike)]

(In reply to comment #13)
> Both feeds from comment 8 don't work for me. Using Linux 2.0.0.14 (20080502)
> version on Kubuntu. Could somebody try it with Thunderbird NOT from Ubuntu
> package but from source to find out if it is due to the way it is packaged for
> Ubuntu?
> 
Sorry about confusion, it's an issue with my profile.

Comment 15

[Merike Sell (:merike)]

It can't be reproduced with new empty profile, but happens when I configure several mail accounts with empty profile and then try to subscribe to, in my case RSS feed with empty title tag. It doesn't occur if I serve the same feed locally from Apache with title element that is not empty.
This bug is still somehow triggered when the title is empty, but not always.
It triggers:

Viga: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgFolder.createSubfolder]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger-newsblog/content/FeedItem.js :: anonymous :: line 209"  data: no]
Lähtefail: chrome://messenger-newsblog/content/FeedItem.js
Rida: 209 

Any suggestions or debugging instructions?

Comment 16

[Magnus Melin [:mkmelin]]

Not really, but file a new bug if you can figure out how to reproduce. This bug is closed.

Comment 17

[Niels]

The problem with a empty title Field persist in Thunderbird 31.5.0.

Comment 18

[Kent James (:rkent)]

Niels, this is a very old, fixed bug. If you have an issue in a current version of Thunderbird, it is a new issue that needs a new bug.