Closed Bug 347965 Opened 18 years ago Closed 18 years ago

get rid of kTitleBarHeight constant in cocoa widgets

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

fix v1.0
2.92 KB, patch
asaf
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
We should get rid of the kTitleBarHeight constant in cocoa widgets. We can do better than that.
Attached patch fix v1.0 — — Splinter Review 

        Attachment #249218 -
        Flags: review?(mark)

    
    

    
  
Comment on attachment 249218 [details] [diff] [review]
fix v1.0

please assert on aWindow in titleBarHeightForWindow.

r=mano otherwise.

        Attachment #249218 -
        Flags: review+

    
  

        Attachment #249218 -
        Flags: review?(mark) → superreview?(mikepinkerton)

    
    

    
  
Comment on attachment 249218 [details] [diff] [review]
fix v1.0

sr=pink

        Attachment #249218 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
landed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: