348090 - sv-SE Search Feature Tracking for Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: sv-SE / Swedish, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[Axel Hecht [:Pike]]

Swedish should use a yahoo-se.xml plugin, referring to se.search.yahoo.com, without suggest.
I bet Swedish users are better off with the UK plugins for Amazon, and/or eBay, too. Mikael, Mic, comments?

Comment 2

[Mic Berman]

I'm OK with UK vs US versions assuming Localizer (Mikael) is?
thanks
mic

Comment 3

[chris hofmann]

Notes from testing Byggets identifierare: Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.8.1b2) Gecko/2006082101 Firefox/2.0b2

Google
http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:sv-SE:official&client=firefox-a
search suggest (föslag) is on, and seems to be returning swedish content

Yahoo
http://search.yahoo.com/search?p=test&ei=UTF-8&fr=moz2

*** http://se.search.yahoo.com/ is available but doesn't seem to be hooked up.  Should the build be switched to this server?

search suggests (föslag) is on, and returns swedish content

Amazon 
http://www.amazon.com/s/103-9872877-2921428?ie=UTF8&tag=mozilla-20&index=blended&link%5Fcode=qs&field-keywords=f%C3%B6rs%C3%A4kringskassan&sourceid=Mozilla-search

*** should we think about switching to UK site like a few of the other euro builds?

Answers
http://www.answers.com/main/ntquery?s=f%C3%B6rs%C3%A4kringskassan&gwp=13

Creative Commons
http://search.creativecommons.org/?q=sweden&sourceid=Mozilla-search

eBay
http://search.ebay.com/sweden_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300
** considered uk or other instead? http://www.ebay.co.uk/

Comment 4

[Stefan [:stefanh]]

> search suggest (föslag) is on, and seems to be returning swedish content

Erm, "föslag"? Are you sure? It should be "förslag"...

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)
> > search suggest (föslag) is on, and seems to be returning swedish content
> 
> Erm, "föslag"? Are you sure? It should be "förslag"...
> 

Nothing wrong with search.properties, so I guess it was a misspell in comment #4 ;-)

Comment 6

[Axel Hecht [:Pike]]

Mikael, Hasse, we'd still need to fix the Yahoo! plugin, and should fix amazon and eBay. See comment 1.

Comment 7

[u60234]

Attachment: patch

Adds plugins for se.search.yahoo.com, Amazon.co.uk, and eBay.se.

Comment 8

[chris hofmann]

looks like this is on track.  nominating as a blocker to make sure it get the right attention for review, landing and testing in the last few days.  thanks for the quick patch

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 238237 [details] [diff] [review]
patch

You should be using the en-GB search plugins. Please give them the same file name and make sure that you merely copied them over.
This significantly reduces the amount of work we have to do to review those.

Thanks

Comment 10

[u60234]

Attachment: patch v2

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 238472 [details] [diff] [review]
patch v2

That looks good.

Comment 12

[u60234]

Checked in on trunk and branch. Can this bug be closed then?

Comment 13

[Axel Hecht [:Pike]]

I'll do that tomorrow, let me check for a run of my toolings, which will happen in 3.5 hours. :-/

Comment 14

[Axel Hecht [:Pike]]

I checked in a bustage fix, it seems like the yahoo-sv-SE.xml file was in latin-1 and not utf-8. I did an iconv dance and checked that in, hopefully that should make sv-SE go green again.

Unsetting fixed1.8.1 for now, Hasse, please verify that my iconv magic resulted in the right 'Sök'.

Comment 15

[u60234]

Yes, the "ö" is correctly coded in UTF-8 now. Thanks for the fix!

Comment 16

[Axel Hecht [:Pike]]

Thanks to Hasse for cross-checking.

Marking FIXED, please test in a nightly and on a fresh profile that all plugins work as expected and VERIFY.

Comment 17

[u60234]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.8.1) Gecko/20060915 BonEcho/2.0.

All plugins worked fine. Search terms with non-ascii chars that are relevant to Swedish all came trough correctly.