Closed
Bug 348121
Opened 18 years ago
Closed 18 years ago
ga-IE Gaelic Search Feature Tracking for Firefox 2
Categories
(Mozilla Localizations :: ga-IE / Irish, defect)
Mozilla Localizations
ga-IE / Irish
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: chofmann, Assigned: kscanne)
References
Details
(Whiteboard: yahoo order?)
Attachments
(2 files)
939 bytes,
patch
|
Pike
:
approval-l10n+
|
Details | Diff | Splinter Review |
2.24 KB,
patch
|
Pike
:
approval-l10n+
|
Details | Diff | Splinter Review |
tracking bug to make sure we get things on the list below working correctly for each locale: Full Default Search partner list/order. primary/secondary search selection behavior Search codes. Search Suggests enable/disable for locales where available or not
Updated•18 years ago
|
Assignee: nobody → kscanne
Component: Other → ga-IE / Irish
QA Contact: brian
Reporter | ||
Comment 1•18 years ago
|
||
looks like search order is incorrect for putting yahoo as second. To confirm, Is this the current order? Google Amazon.co.uk error in yahoo-en-GB.xml A nswers.com Creative Commons eBay.co.uk Should we swap yahoo and amazon? Does anyone know what the xml error for yahoo is, or can fix?
Reporter | ||
Comment 2•18 years ago
|
||
above found if looking at http://people.mozilla.com/~axel/nightly-1.8/search-engines.html
Reporter | ||
Updated•18 years ago
|
Whiteboard: yahoo order?
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #1) > To confirm, Is this the current order? > > Google > Amazon.co.uk > error in yahoo-en-GB.xml A > nswers.com > Creative Commons > eBay.co.uk > > Should we swap yahoo and amazon? Isn't this determined by the order in list.txt? That file has: google yahoo-en-GB amazon-en-GB eBay-en-GB answers creativecommons > > Does anyone know what the xml error for yahoo is, or can fix? > I see a raw "&" in the title ("Yahoo UK & Ireland Search"). Presumably that's bad. I'll fix it to "&" -- do I need check-in approval?
Assignee | ||
Comment 4•18 years ago
|
||
Attachment #235805 -
Flags: approval-l10n?
Comment 5•18 years ago
|
||
Comment on attachment 235805 [details] [diff] [review] add entity for "&" The order is specified in region.properties, and is going to be good. chofmann's report is based on a tool of mine, which doesn't attempt to resurrect ordering for broken plugins, in this case, the Yahoo one.
Attachment #235805 -
Flags: approval-l10n? → approval-l10n+
Comment 6•18 years ago
|
||
Kevin, could you update the ga-IE search plugins with their en-GB equivalents? They lack the SearchForms. I'm not sure what the Yahoo plugin is doing for Gaelic, could you outline that? Might be worth to give it a unique name, if it has a functionality distinct from yahoo-en-GB.xml.
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8final
Reporter | ||
Comment 7•18 years ago
|
||
notes from testing recent build... Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ga-IE; rv:1.8.1b2) Gecko/2006090703 BonEcho/2.0b2 Google "test" gets http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:ga-IE:unofficial&client=firefox-a "An Gréasán" gets http://www.google.com/search?q=An+Gr%C3%A9as%C3%A1n+&ie=utf-8&oe=utf-8&rls=org.mozilla:ga-IE:unofficial&client=firefox-a Search suggest is turned on and returns some Gaelic content for content like "An Gr" Yahoo.co.uk An Gréasán and all searches seem to get this page http://search.yahoo.com/search/options *** we should get this fixed... search suggest is not enabled. Amazon.co.uk http://www.amazon.co.uk/s/026-1354534-0882821?ie=UTF8&tag=firefox-uk-21&index=blended&link%5Fcode=qs&field-keywords=test&sourceid=Mozilla-search Answers http://www.answers.com/main/ntquery?s=An+Gr%C3%A9as%C3%A1n+&gwp=13 some Gaelic/Irish content returned. cc http://search.creativecommons.org/?q=An+Gr%C3%A9as%C3%A1n+&sourceid=Mozilla-search nothing found for search on "An Gréasán" eBay http://search.ebay.co.uk/test_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300
Assignee | ||
Comment 8•18 years ago
|
||
(In reply to comment #6) > Kevin, could you update the ga-IE search plugins with their en-GB equivalents? > They lack the SearchForms. will attach a patch momentarily. > I'm not sure what the Yahoo plugin is doing for Gaelic, could you outline that? > Might be worth to give it a unique name, if it has a functionality distinct > from yahoo-en-GB.xml. There's no difference in functionality. Yahoo has no content localised in Irish, so we make due with the English site.
Assignee | ||
Comment 9•18 years ago
|
||
Attachment #237275 -
Flags: approval-l10n?
Updated•18 years ago
|
Attachment #237275 -
Flags: approval-l10n? → approval-l10n+
Updated•18 years ago
|
Blocks: fx20-ga-IE
Comment 10•18 years ago
|
||
FIXED, please test a nightly build on a fresh profile and VERIFY that all plugins work as expected.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•