348272 - [FIX]Diverting windows into tabs can cause DOM bustage

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:  Load attached testcase.

EXPECTED RESULTS: Pass

ACTUAL RESULTS: Fail

DETAILS: The problem is that the window provider implementation starts an about:blank load in the window it provides.  This can't be worked around in that implementation easily, since just appending a <xul:browser> into the DOM starts such a load in it; the only way to fix this on the provider side would be to either explicitly call stop() or to nor return from provideWindow until the load completes (which is what happens when we actually open a new window).  Given the difficulty of doing the latter, I think the right solution is to just call stop() in the window watcher.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 3

[Boris Zbarsky [:bzbarsky]]

I'd like to land that change on the 1.8 branch too, by the way.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 233153 [details] [diff] [review]
Proposed fix

sr=jst

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 233153 [details] [diff] [review]
Proposed fix

I think we should take this on branch.  This gives us better compat between windows redirected into tabs and just windows.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 233153 [details] [diff] [review]
Proposed fix

a=beltzner on behalf of drivers for the mozilla 181 branch

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed on 1.8 branch.