348421 - The install.js script causes silly strict warnings

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[:Gijs (he/him)]

As in summary. 1.8 branch build reports:

Warning: function install does not always return a value
Source File: https://addons.mozilla.org/js/install.js
Line: 64

Warning: assignment to undeclared variable aPlatform
Source File: https://addons.mozilla.org/js/install.js
Line: 24

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Shut up silly warnings.

Comment 2

[:Gijs (he/him)]

Mike, how swamped are you, and/or is there anyone else I could ask review from? :-)

Comment 3

[Michael Morgan [:morgamic]]

Comment on attachment 233349 [details] [diff] [review]
Patch

Actually, bad idea.  I don't think it should return true by default.

Shouldn't the return false;  get taken out of the if() statement instead?

Comment 4

[Justin Scott [:fligtar]]

The install link is an href to the actual xpi file with an onClick to the install function. So, if they have JS disabled, it will still work.

Taking the return false; out of the if statement would cause the file not to be downloaded at all if for some reason the if() was not true.

Comment 5

[Michael Morgan [:morgamic]]

Comment on attachment 233349 [details] [diff] [review]
Patch

Roger roger -- that's right ; it works.

Comment 6

[Michael Morgan [:morgamic]]

This has been checked in.  Will push with next update.  Thanks for submitting the patch.