348600 - [meta]Keyboard navigation and visual focus issues in Suspected Web Forgery dialog

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[Wayne DeAngelo]

Description:

Test environment:
   Windows XP, Firefox 2 (Bon Echo) build 20060811, 
   Inspect Objects (inspect32) or Event Watcher (accevent32)
   Screen resolution: 1024x768, High Contrast mode: High Contrast #1 (extra large)

Description:
The following visual focus problems were noted on the "Suspected Web Forgery" anti-phishing popup warning:
1. When scroll bars are present in popup window (when large fonts are used) the visual focus does not change to follow the program focus, when tabbing to the buttons in the popup.
2. If you tab out of the warning pop-up window, visual focus is completely lost when tabbing through the links on the grayed-out web page behind the security warning popup.
3. If you select the "Read More" button, program focus goes to some unknown place.  It takes several tabs to get back to the security popup.

Steps to recreate:
1. Set High Contrast #1 (extra large) in Control Panel, accessibility options.  (Note that this results in large fonts.)
    (You can see some of these problems without setting large fonts, but this helps point them out.)
2. Make sure the Google anti-phishing security option is set in the Firefox security options.
    a. Open Firefox Tools, Options, and open Security page.
    b. Select "Tell me if the site I'm using is a suspected forgery" checkbox
    c. Select "Check by asking [Google] about each site I visit" radio button.
3. Open this web page URL in Firefox browser:  http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html
- This results in the display of the "Suspected Web Forgery" pop-up.  (Scroll bars are present when large fonts are selected).

4. Press the Tab key.  This moves program focus to the "Read More >>" button.  Note that visual focus does not change... with large fonts and scroll bars present, the user has no idea where the keyboard focus is at this point.
- The popup window text should visually shift to move the text with program focus into view.
- Note Inspect or Accevent output. It verifies that program focus is on the "Read More >>" button.  AccEvent shows an OBJ_FOCUS change to the "read more" button also.

5. Keep pressing the Tab key.  Focus moves to 
- the "Get me out of here!" button (visual focus does not shift here in large font display)
- then the "Ignore this warning" button  (visual focus does not shift here in large font display)
- then the "Send report" button   (visual focus does not shift here in large font display)
- then the Firefox Navigation toolbar Location field  (Visual focus is okay here)
- then the Firefox Navigation toolbar Search field   (visual focus is okay here)
- then... where?  (no obvious visual focus showing anywhere)
- ... keep pressing Tab and eventually program focus returns to the "Suspected Web Forgery" popup window links.
- It appears the program focus is tabbing through the links on the grayed-out web page displayed behind the "Suspected Web Forgery" popup window.  None of those focus changes can be seen visually.

6. Tab until focus is on the "Read More >>" button.  
7. Press Up Arrow, then Down Arrow keys.  Notice that the text on the window scrolls up and down, as expected, indicating keyboard focus within the security popup window.
8. Press Enter to select the "Read More"  button. Where did visual focus go?
7. After selecting the "read more" button, Press Up Arrow, then Down Arrow.  Note that keyboard focus no longer seems to be in the popup window.
8. Press the Tab key.  Instead of tabbing to the next selectable item within the "Suspected Web Forgery" popup window, it will most often jump up to the "location" field on the Firefox navigation toolbar.  Press Tab a few more times, and focus will eventually return to the security popup window.

Expected results:

1. The visual focus should be clear at all times when tabbing through the dialog.

2. When scroll bars are present in a window, if you tab to a control that is not currently in the visible part of the screen, the visual display should shift to the portion of the window you have tabbed to.  (The current visual focus should mirror the current keyboard focus.)

3. The visual focus should be clear, even when tabbing through the "grayed-out" page behind the security warning.  Question: Is it a good idea to let the user tab to items in the "grayed-out" page before a selection is made on the anti-phishing warning popup?  Shouldn't the page be unreachable until the user has selected the "Ignore this warning" option on the security popup?

4. After selecting the "Read More >>" button, program focus should remain at the top of the security popup window, just as it was when the pop-up first displayed.  Pressing the Up and Down Arrow keys should scroll the text in the window, and pressing Tab should cause focus to move to the next selectable item within the warning popup, rather than jumping to some point outside of the popup.

Comment 1

[Aaron Leventhal]

Doe this need to be split up into several well-defined bugs? I'm overwhelmed reading this, trying to decide if it should block the release.

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381