348657 - brand.dtd is not a well-formed DTD file because of an #expand macro

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[RickieES aka Ricardo Palomares]

Line #1 of mozilla1.8/source/other-licenses/branding/thunderbird/locales/en-US/brand.dtd

is

#expand <!ENTITY  lang.version          "__MOZILLA_LOCALE_VERSION__">

which I don't think is valid syntax in a DTD file. Maybe it is a preprocessor instruction? Perhaps it should be SGML-commented so the file remains a valid DTD file.

Being a non-valid DTD file affects L10n tools like MozillaTranslator, which uses a SAX Parser to load DTD files.

The problem also affects trunk; however, I haven't found the same construction in Firefox or Thunderbird equivalent files.

Comment 1

[Marek Stępień [:marcoos, inactive]]

As I wrote in .l10n, the lang.version entity doesn't seem to be used outside the
/extensions/content-packs/resources/content/pref-contentpacks.xul
file, which is doesn't use Thunderbird's dtd and is only used by SeaMonkey.

It should be safe to remove the whole lang.version entity from brand.dtd.

Comment 2

[Marek Stępień [:marcoos, inactive]]

Attachment: Remove lang.version from brand.dtd

This patch removes the lang.version entity from both brand.dtd's used by Thunderbird.

Comment 3

[Scott MacGregor]

Comment on attachment 233765 [details] [diff] [review]
Remove lang.version from brand.dtd

benjamin might remember if there's a reason for us to define lang.version here.

Comment 4

[Benjamin Smedberg]

Comment on attachment 233765 [details] [diff] [review]
Remove lang.version from brand.dtd

No, that's a leftover from the seamonkey chrome registry I hope.

Comment 5

[Scott MacGregor]

Marek, I landed this patch on the trunk and the branch for you. Thanks again for the fix!