348751 - quadruple-click doesn't work on gtk2/gtk3 backend

Status: RESOLVED INVALID

(Core :: Widget: Gtk, defect)

Description

[Behnam Esfahbod [:zwnj]]

// Find out whether we're doing line or paragraph selection.  If browser.triple_click_selects_paragraph is true, triple-click selects paragraph.  Otherwise, triple-click selects line, and quadruple-click selects paragraph  (on platforms that support quadruple-click).

OO.o support quadruple-click.  I'm going to take a look at it.

Comment 1

[Behnam Esfahbod [:zwnj]]

Looking at GTK2/GDK source code, I found out that it doesn't support quadruple-click.  Is it acceptable to do xlib hacks to get it work?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You man GTK2/GDK can't report quadruple clicks?

If so, an xlib hack is probably OK.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It seems like it could be a bad idea to go against OS conventions for click count.  See http://lists.w3.org/Archives/Public/public-webapi/2006May/0057 (and the testcase in bug 227328) for why.

Comment 4

[Jonathan Watt [:jwatt]]

Closing GTK2 related bugs since we removed GTK2 support at the beginning of 2018 in bug 1278282. Probably best to open a new bug in the unlikely event that any of these are still relevant.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: revised version of testcase from bug 227328 that works today

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is basically still valid, since GTK still increments clickCount as 1, 2, 3, 1, 2, 3, etc.

I'm happy with it being closed given comment 3, though.