Closed
Bug 348809
Opened 18 years ago
Closed 17 years ago
[FIX]Changing the type attribute of form controls needs to notify about various state changes
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(4 files, 1 obsolete file)
22.20 KB,
patch
|
Details | Diff | Splinter Review | |
2.37 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
32.93 KB,
text/html; charset=UTF-8
|
Details | |
2.58 KB,
patch
|
Details | Diff | Splinter Review |
See testcases at http://web.mit.edu/bzbarsky/www/testcases/css-selectors/dynamicChecked-1.html http://web.mit.edu/bzbarsky/www/testcases/css-selectors/dynamicChecked-2.html http://web.mit.edu/bzbarsky/www/testcases/css-selectors/dynamicDefault-1.html http://web.mit.edu/bzbarsky/www/testcases/css-selectors/dynamicDefault-2.html http://web.mit.edu/bzbarsky/www/testcases/css-selectors/dynamicDefault-3.html http://web.mit.edu/bzbarsky/www/testcases/css-selectors/dynamicDefault-4.html I'll check those into our tests too, for this bug. Note that this doesn't address bug 315920 or anything...
Assignee | ||
Updated•18 years ago
|
Priority: -- → P2
Target Milestone: --- → mozilla1.9alpha
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #233949 -
Flags: superreview?(dbaron)
Attachment #233949 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•18 years ago
|
||
Note that I added more testcases for this sort of thing at http://web.mit.edu/bzbarsky/www/testcases/css-selectors/ a while back; the testcases that apply to this bug are in CVS with the appropriate filenames.
Comment 3•18 years ago
|
||
when this lands, please add the tests to mochitest. It should look pretty much like this file: /cvsroot/mozilla/testing/mochitest/tests/test_bug302186.html
Flags: in-testsuite?
Comment on attachment 233949 [details] [diff] [review] Like so > nsHTMLInputElement::IntrinsicState() const > { >+ // If you add states here, and they're type-depedent, you need to add them to depe*n*dent >Index: content/html/content/src/nsGenericHTMLElement.cpp >+ if (doc) { && aNotify ? >Index: content/html/content/src/nsHTMLFormElement.cpp r+sr=dbaron
Attachment #233949 -
Flags: superreview?(dbaron)
Attachment #233949 -
Flags: superreview+
Attachment #233949 -
Flags: review?(dbaron)
Attachment #233949 -
Flags: review+
Assignee | ||
Comment 5•17 years ago
|
||
Attachment #233949 -
Attachment is obsolete: true
Assignee | ||
Comment 6•17 years ago
|
||
Checked in, with tests and trumpets.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Comment 7•17 years ago
|
||
Check again! reftest.list is incorrectly referencing bugs/348801 instead of 348809. This is causing reftest to stall out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•17 years ago
|
||
Attachment #254535 -
Flags: review?(dbaron)
Assignee | ||
Comment 10•17 years ago
|
||
Comment on attachment 254535 [details] [diff] [review] reftest.list patch 348801->348809 That's what I get for doing this late at night... r=bzbarsky
Attachment #254535 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 11•17 years ago
|
||
And checked in.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Now it looks like 4 of the tests are failing. This is from the Linux test log. The Windows log also showed 4 failures (didn't check that they were the same, though).
Comment 13•17 years ago
|
||
The first of the linux tests is an easy fix. It's an extra period at the end of the line "There should be no red".
Comment 14•17 years ago
|
||
incidentally, these are the same tests that are failing on windows.
Assignee | ||
Comment 15•17 years ago
|
||
Yep. The period, and three typos in the moving of onload handlers into inline script... I _really_ shouldn't do tests at night. :( I checked this in. With this, the tests pass as far as I can tell (by manual loading; running the actual test over remote X seems to be very unhappy).
You need to log in
before you can comment on or make changes to this bug.
Description
•