349266 - nsStorageStream publicly implements nsIOutputStream and QIs to it

Status: NEW

(Core :: XPCOM, defect)

Description

[Jeff Walden [:Waldo]]

This basically means that the one-and-only-outputstream (and write) checks are useless:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/io/nsStorageStream.cpp&rev=1.32&mark=117,135#110

I think this might be helped by making nsStorageStream inherit from nsIOutputStream privately (I don't know enough about C++ access modifiers in inheritance to say for sure), although that doesn't eliminate QI-ability.  I'm pretty sure more changes are needed here to ensure this works correctly.

Comment 1

[Alex Vincent [:WeirdAl]]

What if we just made nsIStorageStream inherit from nsIOutputStream, and removed nsIStorageStream::GetOutputStream?

Comment 2

[Alex Vincent [:WeirdAl]]

Oh, we'd have to make nsStorageStream implement nsISeekableStream as well.

Comment 3

[Jeff Walden [:Waldo]]

I'm a bit far away from this thing at this point, but nsIStorageStream, despite having the name "stream" in it, is not is-a stream.  It provides access to an output that you can write to, and it provides access to input(s, if memory serves) that you can read from.  It definitely shouldn't inherit from nsIOutputStream.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.