349562 - Revised qute: Mail history buttons not displayed as small icons

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Cowperthwaite]

When using small icons for toolbars, the mail history buttons (bug 74959) don't appear except for the dropdown-indicator error.

Comment 1

[Mike Cowperthwaite]

Oh, version:  I see this with 2a1-0821, Win2K.

Comment 2

[David :Bienvenu]

my bad - I probably need to do more theme work for the small icon toolbar

Comment 3

[David :Bienvenu]

*** Bug 349563 has been marked as a duplicate of this bug. ***

Comment 4

[David :Bienvenu]

Attachment: fix for qute theme

this fixes qute - I'm going to wait for the new pinstripe theme to fix pinstripe...

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 234870 [details] [diff] [review]
fix for qute theme

sr=sspitzer, acting sr for mailnews while mscott is away

Comment 6

[David :Bienvenu]

fixed on trunk and branch (though small icons on trunk don't seem too happy)

Comment 7

[Mike Cowperthwaite]

(In reply to comment #6)
> fixed on trunk and branch (though small icons on trunk don't seem too happy)

David, what problems did you see?  I've just tried out all sorts of permutations of these icons (small and large, with and without text, standalone and 3pane) and saw no rendering or behavior issues.  Used 3a1-0907, Win2K.

Comment 8

[David :Bienvenu]

for pinstripe, we just (re)use the next unread/prev unread buttons for the back forward history buttons. 

I can't remember exactly what problems I saw, but they're definitely fixed on the trunk now...