Closed Bug 349737 Opened 18 years ago Closed 18 years ago

XULRunner Software Update restarts app in a disabled state on OS X

Categories

(Toolkit Graveyard :: XULRunner, defect)

Product:
Toolkit Graveyard
Component:
XULRunner
Version:
1.8 Branch
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

[1.8 Branch - CHECKED IN] Patch v1.0
3.14 KB, patch
benjamin
: first-review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
[Trunk - CHECKED IN] Patch v1.0
3.06 KB, patch
benjamin
: first-review+
Details | Diff | Splinter Review 
OS X needs a little massaging in order to let XULRunner apps restart properly after a failed or successful update. The basic problem is that launching xulrunner-bin as a GUI app requires some trickery (see http://lxr.mozilla.org/mozilla1.8/source/xulrunner/stub/nsXULStubOSX.cpp#146) and the updater.app isn't doing it properly atm. The solution is to pass the location of the stub executable instead of xulrunner-bin to the updater.
per bsmedberg, requesting blocking.
Flags: blocking-firefox2?
Not going to block Firefox 2 on this, but will take a branch-safe patch.
Flags: blocking-firefox2?
Here's one option for fixing this on the branch. I've verified that the app restarts correclty now.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #235123 - Flags: first-review?(benjamin)
Attachment #235123 - Flags: first-review?(benjamin) → first-review+
Comment on attachment 235123 [details] [diff] [review]
[1.8 Branch - CHECKED IN] Patch v1.0

This patch adds a small change to OSX XULRunner apps only, and I have verified that it fixes the issue perfectly. AFAICT it should therefore be very safe to take on the branch at this point.
Attachment #235123 - Flags: approval1.8.1?
Comment on attachment 235123 [details] [diff] [review]
[1.8 Branch - CHECKED IN] Patch v1.0

a=beltzner on behalf of drivers for the MOZILLA_1_8_BRANCH
Attachment #235123 - Flags: approval1.8.1? → approval1.8.1+
Checked in on branch. Leaving open for trunk solution.
Keywords: fixed1.8.1
Attachment #235123 - Attachment description: [1.8 Branch] Patch v1.0 → [1.8 Branch - CHECKED IN] Patch v1.0
Trunk patch, identical except no longer wrapped in '#ifdef MOZ_XULRUNNER'.
Attachment #235276 - Flags: first-review?(benjamin)
Attachment #235276 - Flags: first-review?(benjamin) → first-review+
Comment on attachment 235276 [details] [diff] [review]
[Trunk - CHECKED IN] Patch v1.0

Fixed on trunk.
Attachment #235276 - Attachment description: [Trunk] Patch v1.0 → [Trunk - CHECKED IN] Patch v1.0
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: