Closed Bug 349855 Opened 18 years ago Closed 18 years ago

editgroups.cgi doesn't protect the querysharegroup from deletion

Categories

(Bugzilla :: Administration, task)

Product:
Bugzilla
Component:
Administration
Version:
2.23
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: Wurblzap, Assigned: LpSolit)

References

Details

(Keywords: selenium)

Attachments

(1 file)

patch, v1
3.25 KB, patch
mkanat
: review+
Details | Diff | Splinter Review 
editgroups.cgi protects “Special Groups” from deletion by including them into a certain array. The querysharegroup should be included in this array. Additionally, template/en/default/admin/groups/list.html.tmpl should know about this as well and make the protection visible in the bug list, as it does for the other “Special Groups”.
Whiteboard: [Good intro bug]
Flags: blocking3.0?
Yeah, this should be fixed for 3.0--it could cause database corruption and strange errors.
Flags: blocking3.0? → blocking3.0+
Attached patch patch, v1 — — Splinter Review 
This patch also includes the fix for bug 357429.
Assignee: administration → LpSolit
Status: NEW → ASSIGNED
Attachment #242913 - Flags: review?(mkanat)
Whiteboard: [Good intro bug]
Comment on attachment 242913 [details] [diff] [review]
patch, v1

This looks correct to me.

r=mkanat by inspection
Attachment #242913 - Flags: review?(mkanat) → review+
Flags: approval?
Blocks: 357429
Flags: approval? → approval+
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.82; previous revision: 1.81
done
Checking in template/en/default/admin/groups/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/qa/4.4/
modified t/test_groups.t
Committed revision 239.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/qa/4.2/
modified t/test_groups.t
Committed revision 229.
Flags: testcase+
Keywords: selenium
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: