Closed
Bug 350363
Opened 18 years ago
Closed 7 years ago
MOZ_XMLEXTRAS(--disable-xmlextras) not used by toolkit
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: romaxa, Unassigned)
Details
Attachments
(1 file)
2.78 KB,
patch
|
benjamin
:
first-review-
|
Details | Diff | Splinter Review |
MOZ_XMLEXTRAS option supposed to be disabled with --disable-xmlextras configure option, but toolkit/library libxul-config.mk and nsStaticXULComponents.cpp not use this define... and linking failed... Patch in attachment
Reporter | ||
Comment 1•18 years ago
|
||
Attachment #235630 -
Flags: first-review?(timeless)
Comment on attachment 235630 [details] [diff] [review] BUILDFIX xmlextras isn't realistically optional especially for people who care about google apps, but that should be configurator's problem
Attachment #235630 -
Flags: first-review?(timeless) → first-review+
Reporter | ||
Comment 3•17 years ago
|
||
(In reply to comment #2) > (From update of attachment 235630 [details] [diff] [review]) > xmlextras isn't realistically optional especially for people who care about > google apps, but that should be configurator's problem > I don't ask to disable xmlextras by default, I just don't want to have problem with building libxul when MOZ_XMLEXTRAS disabled
Reporter | ||
Comment 4•17 years ago
|
||
Any superreview?
Comment 5•17 years ago
|
||
Comment on attachment 235630 [details] [diff] [review] BUILDFIX We should not have the --disable-xmlextras build option. We do not want to ever disable it, even in the smallest embedding profile. This bug is either WONTFIX or should be morphed to remove the flag altogether. See http://wiki.mozilla.org/Gecko:Small_Device_Support
Attachment #235630 -
Flags: first-review+ → first-review-
Comment 6•17 years ago
|
||
http://wiki.mozilla.org/Gecko:Small_Device_Support lists XMLHttpRequest, DOMParser, and DOMSerializer. But those have been moved from mozilla/extensions/xmlextras/base to mozilla/content/base by bug 324865. So what about the rest? Should we fix the option to turn it off (this bug), or remove --disable-xmlextras and the MOZ_XMLEXTRAS ifdefs?
Reporter | ||
Comment 7•17 years ago
|
||
I think we have to remove this option, because it useless already
Comment 8•7 years ago
|
||
MOZ_XMLEXTRAS no longer exists.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•