350363 - MOZ_XMLEXTRAS(--disable-xmlextras) not used by toolkit

Status: RESOLVED INVALID

(Toolkit Graveyard :: Build Config, defect)

Description

[Oleg Romashin (:romaxa)]

MOZ_XMLEXTRAS option supposed to be disabled with --disable-xmlextras configure option, but toolkit/library libxul-config.mk and nsStaticXULComponents.cpp not use this define...  and linking failed...

Patch in attachment

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: BUILDFIX

Comment 2

[timeless]

Comment on attachment 235630 [details] [diff] [review]
BUILDFIX

xmlextras isn't realistically optional especially for people who care about google apps, but that should be configurator's problem

Comment 3

[Oleg Romashin (:romaxa)]

(In reply to comment #2)
> (From update of attachment 235630 [details] [diff] [review])
> xmlextras isn't realistically optional especially for people who care about
> google apps, but that should be configurator's problem
> 
I don't ask to disable xmlextras by default, I just don't want to have problem with building libxul when MOZ_XMLEXTRAS  disabled

Comment 4

[Oleg Romashin (:romaxa)]

Any superreview?

Comment 5

[Benjamin Smedberg]

Comment on attachment 235630 [details] [diff] [review]
BUILDFIX

We should not have the --disable-xmlextras build option. We do not want to ever disable it, even in the smallest embedding profile. This bug is either WONTFIX or should be morphed to remove the flag altogether. See http://wiki.mozilla.org/Gecko:Small_Device_Support

Comment 6

[Steffen Wilberg]

http://wiki.mozilla.org/Gecko:Small_Device_Support lists 
XMLHttpRequest, DOMParser, and DOMSerializer. But those have been moved from mozilla/extensions/xmlextras/base to mozilla/content/base by bug 324865.
So what about the rest? Should we fix the option to turn it off (this bug), or remove --disable-xmlextras and the MOZ_XMLEXTRAS ifdefs?

Comment 7

[Oleg Romashin (:romaxa)]

I think we have to remove this option, because it useless already
 

Comment 8

[Gregory Szorc [:gps]]

MOZ_XMLEXTRAS no longer exists.