350742 - Missing left (and right) margin for address and search bars

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Simon Bünzli]

If you move either of them to the very left of a toolbar, they look quite squeezed - and when moved to the right of the menu bar, there's no margin between the right-most menu and the bar at all.

Not sure how this will be handled when the Go button can be removed separately, but when done through CSS, there's currently no margin to the right either.

Comment 1

[Simon Bünzli]

Attachment: screenshot

BTW: Spacing between the individual elements still looks slightly flaky in general.

Comment 2

[Simon Bünzli]

After the Winstripe rollup, in the default layout the Home button's bevel now touches the address bar which looks kind of weird (especially since there's margin above and below the address bar). Requesting blocking.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, now that we're using system bevels, this is strange. I'll find someone to take this. Marking theme change, even though I don't know if it is, but just to get it to show up in the right queries.

Comment 4

[Peter Kasting]

*** Bug 347720 has been marked as a duplicate of this bug. ***

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Adds a left margin to the urlbar and search bar.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: before&after screenshot

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 238005 [details] [diff] [review]
patch

r+a=me, let's get this in ASAP.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/winstripe/browser/browser.css 	1.17.2.57