350845 - Implement relevant parameter methods (enumerate, exists, set)

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Matthew (lilmatt) Willis]

spinoff from bug 322831:

"Please file another bug for implementing other relevant
parameter methods (enumerate, exists(?), set)."

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Taking, I have a patch for this I will upload later. One thing I noticed during testing, it doesn't seem to be possible to use non-X parameters, they get lost on roundtrip. Is this wanted behavior? Example:

createEventFromIcalString("BEGIN:VEVENT\nX-FOO;BAR=BAZ:QUUX\nEND:VEVENT").icalString

->  X-FOO:QUUX

createEventFromIcalString("BEGIN:VEVENT\nX-FOO;X-BAR=BAZ:QUUX\nEND:VEVENT").icalString

->  X-FOO;X-BAR=BAZ:QUUX

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

The Promised patch, with tests

Comment 3

[Markus Adrario [:Taraman]]

Comment on attachment 397915 [details] [diff] [review]
Fix - v1

Patch looks good.

Test passes:
TEST-PASS | 
C:\mozilla-build\msys\home\Markus\comm-1.9.1\objdir-sb-release\mozilla\_tests\xpcshell\test_calendar\unit\test_bug350845.js
| test passed

r=markus

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4f0d6958bf72>
and comm-1.9.1 <http://hg.mozilla.org/releases/comm-1.9.1/rev/03133384ab3e>

-> FIXED