Closed Bug 351126 Opened 18 years ago Closed 10 years ago

Patch for bug 237085 makes us call GetMaxChunkLength too much

Categories

(Core Graveyard :: GFX, defect)

Product:
Core Graveyard
Component:
GFX
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: bzbarsky, Unassigned)

References

Details

(Keywords: perf) 

The patch for bug 237085 added calls to GetMaxChunkLength to the various GFX apis.  Unfortunately, some API functions call other API functions.  :(  Typical example:

nsRenderingContextImpl::GetTextDimensions calls GetMaxChunkLength.

It also calls nsThebesRenderingContext::GetTextDimensionsInternal which calls nsThebesRenderingContext::GetWidth which calls nsRenderingContextImpl::GetWidth which calls GetMaxChunkLength.

Perhaps GetTextDimensionsInternal should be calling GetWidthInternal directly?  Or something like that?
Flags: blocking1.9?
Summary: Patch for bug 237085 makes us call GetMaxChunkLength to much → Patch for bug 237085 makes us call GetMaxChunkLength too much
But, this code won't live long on trunk, so this is only a branch issue.
I don't really care about branch.  This function is pretty fast except with cairo.  I assume on trunk the textframe rewrite is making this go away?
Depends on: 351242
No longer depends on: 351242
code going away, so not blocking
Flags: blocking1.9? → blocking1.9-
Product: Core → Core Graveyard
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.