351472 - Building trunk with GCC 3.2.2 on OS/2 fails in java_xpcom.c

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[Peter Weilbacher]

Following the checkin from bug 333618 java_xpcom.c does not compile any more on OS/2 with GCC 3.2.2:

I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c: In function 
`interface_declaration':
I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c:253: `PATH_MAX' undeclared 
(first use in this function)
I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c:253: (Each undeclared 
identifier is reported only once
I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c:253: for each function it 
appears in.)

It seems that GCC 3.2.2 does not define MAX_PATH by default.

Comment 1

[Peter Weilbacher]

Attachment: the fix

This should fix it.

But I wonder if the same patch is needed for extensions/java/xpcom/tools/xpidl/xpidl_java.c.

Comment 2

[jhp (no longer active)]

Comment on attachment 236865 [details] [diff] [review]
the fix

Looks good.  None of the code in extensions/java/xpcom/tools is used any more after bug 333618, so don't worry about it.

Comment 3

[Peter Weilbacher]

Checked into trunk.

Comment 4

[Peter Weilbacher]

Comment on attachment 236865 [details] [diff] [review]
the fix

Not that the respective patch for bug 333618 went into MOZILLA_1_8_BRANCH we should get this in, too.

Comment 5

[Mike Schroepfer]

Comment on attachment 236865 [details] [diff] [review]
the fix

a=schrep for os2 build fix.