351474 - No reaction to WM_QUIT

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Peter Weilbacher]

With the threading changes in May 2006 the handling of WM_QUIT that previously lived in nsAppShell::Exit and nsAppShell::Run has gone away. The symptom is that when a SeaMonkey or Firefox window is closed from the Window List of the system nothing happens (besides that window getting focus).

Solutions would be to resurrect the code that was removed and put it into some other method or to just handle WM_QUIT like WM_CLOSE.

Comment 1

[Peter Weilbacher]

Attachment: The easy fix

Mike, please tell me if this easy fix makes sense to you (at least my limited testing does't show any bad effects), or if I should look into getting the old code back into OS/2's nsAppShell somehow.

Comment 2

[Mike Kaply [:mkaply]]

If you have multiple windows open and right click on one in the task list and select close, does it close all or just the one (with this patch)

Comment 3

[Peter Weilbacher]

In my testing with this patch it closed the one selected window only.

Comment 4

[Mats Palmgren (inactive)]

Related to bug 344440?

Comment 5

[Peter Weilbacher]

Mats, yes the reason for the problem is the same. But I think we should not solve the problem in the same way as it has been done on Windows (in bug 344309) because that will shut down the app completely without asking instead of just closing a window. The solution that was suggested in bug 344440 does not seem to work, either. nsIAppStartup::Quit(eAttemptQuit) always just closes without asking while Quit(eConsiderQuit) doesn't seem to do anything.

I think the solution in attachment 236871 [details] [diff] [review] is better, but I don't know all the implications that this will have when installing and on extensions.

Comment 6

[Peter Weilbacher]

mkaply, are you happy with the simple solution? If yes, we should get this in soon, because the nightly users get more and more unhappy about this.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 236871 [details] [diff] [review]
The easy fix

Yep. This is good enough for now.

Comment 8

[Peter Weilbacher]

OK, fix checked into trunk (not needed for branch).