351549 - Remove nsXULTreeAccessibleWrap and nsXULMenuAccessibleWrap headers (for those that don't need it)

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, defect)

Description

[Håkan Waara]

The following files can be remove, since the typedefs are not necessary (after a tiny change in nsAccessibilityService.cpp):

for other/ and mac/:
nsXULMenuAccessibleWrap.h
nsXULTreeAccessibleWrap.h

for atk/:
nsXULMenuAccessibleWrap.h

Comment 1

[Håkan Waara]

Attachment: Patch v1

Aaron, I've omitted the Makefile.in change for mac but it's identical to that of other/Makefile.in

I'll make it upon checkin. (I have too many other changes there right now due to my other work.)

Comment 2

[Aaron Leventhal]

Comment on attachment 236961 [details] [diff] [review]
Patch v1

This won't work, let me explain.

We need to create nsXULMenuAccesibleWrap etc. in nsAccessibilityService. In fact, this bug shows me that the remote XUL fix in nsAccessibilityService broke that. We're not creating the Wrap classes we used to.

Comment 3

[Aaron Leventhal]

So when we fix the regression from bug 241015 where the Wrap classes are no longer being created, it will break this fix because those symbols will no longer be in nsAccessibilityService.

Comment 4

[Håkan Waara]

I wish we could do some kind of fallback that accessible/src/base would use for these wrap classes, so we don't have to have all these boilerplate headers (with only one typedef in them)...