Closed
Bug 351988
Opened 18 years ago
Closed 18 years ago
e4x adds spurious quotes when decompiling an XMLPI object initializer
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
Details
(Keywords: verified1.8.1)
Attachments
(1 file)
891 bytes,
patch
|
brendan
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
js> var x = function() { var y = <?foo bar?>; } function () { var y = <?foo "bar"?>; }
Comment 1•18 years ago
|
||
js> var x = function() { var y = <?foo bar?>; } js> x function () { var y = <?foo "bar"?>; } js> dis(x) flags: LAMBDA main: 00000: string "bar" 00003: xmlpi "foo" 00006: setvar 0 00009: pop 00010: stop Source notes: 0: 6 [ 6] decl offset 0 Trivial fix suggests itself: use JSOP_QNAMEPART instead of JSOP_STRING for the first bytecode. Robert, you gonna take this one? /be
Assignee | ||
Comment 2•18 years ago
|
||
Comment 3•18 years ago
|
||
Comment on attachment 237571 [details] [diff] [review] use JSOP_QNAMEPART Cool, thanks. Trivially safe and good for 1.8.1 if you want to nominate, and to help the decompiler fuzzer avoid a special case. /be
Attachment #237571 -
Flags: review?(brendan) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Checking in jsemit.c; /cvsroot/mozilla/js/src/jsemit.c,v <-- jsemit.c new revision: 3.205; previous revision: 3.204 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Attachment #237571 -
Flags: approval1.8.1?
Comment 5•18 years ago
|
||
Comment on attachment 237571 [details] [diff] [review] use JSOP_QNAMEPART a=schrep for JS decompiler bugs
Attachment #237571 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 6•18 years ago
|
||
Checking in jsemit.c; /cvsroot/mozilla/js/src/jsemit.c,v <-- jsemit.c new revision: 3.128.2.41; previous revision: 3.128.2.40 done
Keywords: fixed1.8.1
Comment 7•18 years ago
|
||
Checking in regress-351988.js; /cvsroot/mozilla/js/tests/e4x/Regress/regress-351988.js,v <-- regress-351988.js initial revision: 1.1 done
Flags: in-testsuite+
Comment 8•18 years ago
|
||
verified fixed 1.8 1.9 2006091022 windows/mac*/linux
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•