352448 - "Feed Preferences..." menu item does not activate General prefs pane

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Chris Lawson (gone)]

Summary pretty much says it all. This menu item should activate the General prefs pane, since that's where the only RSS-related pref lives.

This works fine on first launch, so to reproduce, you need to have previously opened prefs and selected something besides the General pane.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

In case it's any help, the old popup blocker's menu item to "configure pop-up blocking" worked correctly.

Comment 2

[Sean Murphy]

Attachment: BrowserWindowController.mm: Open Feed Preferences Patch

The preference window is opened to a specific panel using an identifier (belonging to the bundle).  The feed preferences are located in the first pane, which has an identifier of org.mozilla.camino.preference.navigation.  The bug was occurring because the openFeedPrefPane: method was using org.mozilla.camino.preference.general as that identifier.

I'm betting the first panel was originally titled 'navigation', but has since been changed to 'general' (in the interface that is - the bundle identifier has always been navigation).

Comment 3

[Nick Kreeger]

Comment on attachment 239447 [details] [diff] [review]
BrowserWindowController.mm: Open Feed Preferences Patch

r=me

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 239447 [details] [diff] [review]
BrowserWindowController.mm: Open Feed Preferences Patch

sr=pink

Comment 5

[Nick Kreeger]

Checked into trunk and MOZILLA_1_8_BRANCH.