Closed
Bug 353033
Opened 18 years ago
Closed 18 years ago
regression: Edit->Delete and Edit->Switch Text Direction are always enabled
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1, regression)
Attachments
(1 file)
|
1.35 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Once "Switch Text Direction" is enabled (by focusing something-editable), it stays enabled even when elements which are not editable are focused (content area, tabs etc.). This works fine in Fx 1.5.0.x. Simon was able to reproduce this on windows too. Other than polish, this probably leads to a confusion on what Edit->Switch Text Direction stands for, see bug 352645.
|
Assignee | |
Updated•18 years ago
|
Flags: blocking-firefox2?
|
|
Assignee | |
Updated•18 years ago
|
OS: Mac OS X 10.3 → All
Hardware: Macintosh → All
|
|
Assignee | |
Comment 1•18 years ago
|
||
OK, this is an API regression from bug 317633, we no longer disable commands if they don't have a controller in the current context (which is the way this works since the beginning of time).
|
|
Assignee | |
Comment 2•18 years ago
|
||
Drivers: without this fix, extensions which add command controllers are broken as well ("BiDi Mail UI" for example).Assignee: nobody → mano
Status: NEW → ASSIGNED
Attachment #238881 -
Flags: review?(mconnor)
Attachment #238881 -
Flags: approval1.8.1?
|
|
Assignee | |
Comment 3•18 years ago
|
||
Also happens with the delete menu item once text is selected in any text field.
Summary: regression: Edit->Switch Text Direction is always enabled → regression: Edit->Delete and Edit->Switch Text Direction is always enabled
|
|
Assignee | |
Updated•18 years ago
|
Summary: regression: Edit->Delete and Edit->Switch Text Direction is always enabled → regression: Edit->Delete and Edit->Switch Text Direction are always enabled
|
||
Comment 4•18 years ago
|
||
Comment on attachment 238881 [details] [diff] [review] patch hmm, this is Places fallout it seems, at least we caught it I guess
Attachment #238881 -
Flags: review?(mconnor)
Attachment #238881 -
Flags: review+
Attachment #238881 -
Flags: approval1.8.1?
Attachment #238881 -
Flags: approval1.8.1+
|
|
Assignee | |
Comment 5•18 years ago
|
||
1.8: mozilla/toolkit/content/globalOverlay.js 1.18.8.9
Keywords: fixed1.8.1
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
|
Assignee | |
Comment 6•18 years ago
|
||
trunk: mozilla/toolkit/content/globalOverlay.js 1.28
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•