353071 - Simplify visibility checks in OpenLocation and getSearchBar

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Asaf Romano (gone)]

We can do simple checks on the boxObject of the location bar and search bar elements instead of checking their containers visibility etc.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 238937 [details] [diff] [review]
patch

>Index: browser/base/content/browser.js

>   var element;
>-  if (gIsLoadingBlank && gURLBar && !gURLBar.hidden &&
>-      !gURLBarContainer.parentNode.collapsed)
>+  if (gIsLoadingBlank && gURLBar && isElementVisible(gURLBar))
>     element = gURLBar;
>   else
>     element = content;

>-  if (gURLBar) {
>-    var style = document.defaultView.getComputedStyle(gURLBarContainer, null);
>-    if (style.visibility == "visible" && style.display != "none") {
>-      gURLBar.focus();
>-      gURLBar.select();
>-      return;
>-    }
>+  if (gURLBar && isElementVisible(gURLBar)) {
>+    gURLBar.focus();
>+    gURLBar.select();
>+    return;

gURLBarContainer is now unused, so you can remove it.

>Index: browser/base/content/utilityOverlay.js

>+function isElementVisible(aElement)
>+{
>+  // * When an element is hidden (not collapsed), its boxObject.x property is
>+  //   set to 0.

This is also true for elements on the leftmost edge of the screen, though... You should probably check at least one of width and height, too. I kinda of wish there was a better way to tell whether an element has a frame or not (or maybe there is and I don't know about it - maybe one of the Neils would?). Also, use document.defaultView.getComputedStyle instead of window.getComputedStyle.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 239426 [details] [diff] [review]
patch

r=me if you also remove other traces of gURLBarContainer.

Comment 5

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/base/content/browser.js 1.708
mozilla/browser/base/content/utilityOverlay.js 1.43