Closed Bug 353964 Opened 18 years ago Closed 18 years ago

Popup menu for select widgets appears too far up.

Categories

(Camino Graveyard :: HTML Form Controls, defect)

Product:
Camino Graveyard
Component:
HTML Form Controls
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino1.5

People

(Reporter: moz, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.0.12, fixed1.8.1.4, regression)

Attachments

(2 files)

Screenshot
17.86 KB, image/png
Details
fix origin
1.43 KB, patch
hwaara
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review 
In the September 22 nightly, clicking on a <select> widget causes the menu to appear approximately 1 item too high.

Screenshot forthcoming.
Attached image Screenshot — 

    
  
Keywords: regression

    
    

    
  
Did this just regress, or has it been happening for a bit?  I seem to recall hwaara checking in some coordinate-changing stuff in Cocoa widgets not too long ago and perhaps that influenced this?  

(I see this too, in my build, but I don't have trunk nightlies or a useful connection so I can't find ranges)
Hardware: PC → Macintosh

    
    

    
  
(In reply to comment #2)
> Did this just regress, or has it been happening for a bit?  I seem to recall
> hwaara checking in some coordinate-changing stuff in Cocoa widgets not too long
> ago and perhaps that influenced this?  

bug 350018 ?




    
    

    
  
I see the problem on trunk with Version 2006092200 (1.2+)
but not with Version 2006091922 (1.2+)
No official builds in between.


An own trunk build, compiled 0922 15:15 Japan Time shows the problem (that should be  0921 late evening PDT).

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix origin
        — 
          — Splinter Review
      

    


  
Updates the coord conversion to adjust the newly upper-left origin to a lower-left origin.
Assignee: nobody → stuart.morgan
Status: NEW → ASSIGNED

        Attachment #239868 -
        Flags: superreview?(sfraser_bugs)

        Attachment #239868 -
        Flags: review?(hwaara)

    
    

    
  
Comment on attachment 239868 [details] [diff] [review]
fix origin

Thanks for fixing this, Stuart.

        Attachment #239868 -
        Flags: review?(hwaara) → review+

        Attachment #239868 -
        Flags: superreview?(sfraser_bugs) → superreview+

    
    

    
  
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Target Milestone: --- → Camino1.1

    
    

    
  
Backed out on branch.  Sorry, didn't see that this was trunk only.
Keywords: fixed1.8.1

    
    

    
  
Bug 350018 is going on the branch, so we need this for 1.1 now too.

    
    

    
  
Checked in on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.12, 
          
            fixed1.8.1.4

    
    

    
  
+ing this for housekeeping purposes.
Flags: camino1.0.5+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: