Closed Bug 354008 Opened 18 years ago Closed 18 years ago

klocwork bugs in freebl

Categories

(NSS :: Libraries, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nelson, Assigned: alvolkov.bgs)

Details

(Keywords: klocwork)

Attachments

(1 file)

ID:       91218
Function: mp_div
Location: nss/lib/freebl/mpi/mpi.c : 1006

Dereference of pointer 'a' at line 1006 before NULL check at line 1009

1006	  mp_sign  signA = MP_SIGN(a); 
1007	  mp_sign  signB = MP_SIGN(b); 
1008	 
1009	  ARGCHK(a != NULL && b != NULL, MP_BADARG); 

----

ID 91219

Same issue as above, but for pointer variable b at line 1007, 1009
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #240226 - Flags: review?(nelson)
Priority: -- → P2
Target Milestone: --- → 3.12
Comment on attachment 240226 [details] [diff] [review]
check args before deref pointers

r=nelson for trunk
Attachment #240226 - Flags: review?(nelson) → review+
/cvsroot/mozilla/security/nss/lib/freebl/mpi/mpi.c,v  <--  mpi.c
new revision: 1.45; previous revision: 1.44
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: