Closed Bug 354144 Opened 18 years ago Closed 18 years ago

[FIX] position:absolute is broken

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: Peter6, Assigned: bzbarsky)

References

Details

(4 keywords)

Attachments

(3 files, 1 obsolete file)

Include the header too
4.85 KB, patch
roc
: review+
roc
: superreview+
dveditz
: approval1.8.0.8-
dveditz
: approval1.8.0.9+
dveditz
: approval1.8.1.1+
Details | Diff | Splinter Review
Branch version
4.91 KB, patch
Details | Diff | Splinter Review
testcase
288 bytes, text/html
Details 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060924 Minefield/3.0a1 ID:2006092421 [cairo]

repro:

open gmail and stare at a white screen
(visable on many sites)
*** Bug 354088 has been marked as a duplicate of this bug. ***
Also happens here on OS X.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060925 Minefield/3.0a1
OS: Windows 2000 → All
Hardware: PC → All
Attached patch Fix (obsolete) — — Splinter Review 
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

        Attachment #240024 -
        Flags: superreview?(roc)

        Attachment #240024 -
        Flags: review?(roc)

    
    

    
  
This is what I get for testing changes in my local builds.  :(
Priority: -- → P1
Summary: position:absolute is broken → [FIX] position:absolute is broken
Target Milestone: --- → mozilla1.9alpha

    
    

    
  


  

        Attachment #240024 -
        Attachment is obsolete: true

        Attachment #240028 -
        Flags: superreview?(roc)

        Attachment #240028 -
        Flags: review?(roc)

        Attachment #240024 -
        Flags: superreview?(roc)

        Attachment #240024 -
        Flags: review?(roc)

        Attachment #240028 -
        Flags: superreview?(roc)

        Attachment #240028 -
        Flags: superreview+

        Attachment #240028 -
        Flags: review?(roc)

        Attachment #240028 -
        Flags: review+

    
    

    
  
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 240028 [details] [diff] [review]
Include the header too

If we decide to take bug 330909 for a release, we need to take this too.

        Attachment #240028 -
        Flags: approval1.8.0.8?

    
  
Flags: blocking1.8.1.1?

    
    

    
  
*** Bug 354202 has been marked as a duplicate of this bug. ***

    
    

    
  
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060925 Minefield/3.0a1 ID:2006092520 [cairo]

VERIFIED/FIXED for win32

        Attachment #240028 -
        Flags: approval1.8.0.9?

        Attachment #240028 -
        Flags: approval1.8.0.8?

        Attachment #240028 -
        Flags: approval1.8.0.8-

    
    

    
  
*** Bug 354382 has been marked as a duplicate of this bug. ***

    
  
Flags: blocking1.8.0.9?
Flags: blocking1.8.1.1?
Flags: blocking1.8.1.1+
Flags: blocking1.8.0.9?
Flags: blocking1.8.0.9+

    
    

    
  
Comment on attachment 240028 [details] [diff] [review]
Include the header too

Approved for 1.8.0/1.8 branches, a=dveditz for drivers

        Attachment #240028 -
        Flags: approval1.8.1.1+

        Attachment #240028 -
        Flags: approval1.8.0.9?

        Attachment #240028 -
        Flags: approval1.8.0.9+

    
    

    
  
Boris could you please fix this together with bug 330909 on branches, I wouldn't like to checkin bug 330909 without the patch from this bug.

    
    

    
  
Yeah, once the 1.8.0 branch opens.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Branch version
        — 
          — Splinter Review
      

    


  

    
    

    
  
Fixed for 1.8.1 and 1.8.0.9
Keywords: fixed1.8.0.9, 
          
            fixed1.8.1

    
    

    
  
I meant 1.8.1.1.
Keywords: fixed1.8.1 → fixed1.8.1.1

    
    

    
  
Martijn and I verified bug 330909, but is there any easy way to test this fix?  If anyone has a testcase, please share.
Whiteboard: [need testcase]

    
    

    
  
This patch basically should have been part of the patch for bug bug 330909.
It's not possible to verify this for branch (unless by code inspection), it was a trunk regression that was caused by the patch for bug bug 330909.

    
    

    
  

      
      
      
      

        Attached file
          
        testcase
        — 
      

    


  
the yellow square should be 100px from the top and 100px from the left

    
    

    
  
v.fixed on Trunk, as well as 1.8.0 and 1.8.1 branches, with Peter's testcase.  Yellow square's absolute position looks correct, so whatever was fixed for the Trunk did not introduce any regression on the branches for this testcase.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.9, 
          
            fixed1.8.1.1 → verified1.8.0.9, 
          
            verified1.8.1.1

    
  
Keywords: testcase
Whiteboard: [need testcase]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: