354381 - New profiles without default tags (MigrateLabelsToTags broken)

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Karsten Düsterloh]

Newly created profiles lack the five default tags (former labels), both in context menus and preferences.

Comment 1

[Karsten Düsterloh]

Attachment: use correct prefBranch

Comment 2

[David :Bienvenu]

Comment on attachment 240210 [details] [diff] [review]
use correct prefBranch 

Thx for the fix...

Just to be sure I understand, it looks like this broke when m_prefBranch was made to always point to mailnews.tags...maybe m_prefBranch should be renamed to something like m_tagsPrefSubBranch or something to be clearer. Also, getPrefService should be removed, as well as the calls to it, since it's not going to do the right thing.

Comment 3

[Karsten Düsterloh]

Attachment: prefBranch correction + additional clean-up, v2

Additional clean-up as proposed in comment #2.

> Just to be sure I understand, it looks like this broke when m_prefBranch was
> made to always point to mailnews.tags...

Yes. Sorry about that. :(

Comment 4

[David :Bienvenu]

Comment on attachment 240346 [details] [diff] [review]
prefBranch correction + additional clean-up, v2

looks good, thx.

Comment 5

[Karsten Düsterloh]

Comment on attachment 240346 [details] [diff] [review]
prefBranch correction + additional clean-up, v2

TB/SM only, low risk, regression fix.

Checked in on trunk.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 240346 [details] [diff] [review]
prefBranch correction + additional clean-up, v2

a=beltzner on behalf of drivers

Comment 7

[Karsten Düsterloh]

Landed on MOZILLA_1_8_BRANCH.

Comment 8

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 - new profile has default tags -> adding verified keyword