354565 - fipstest sha_test needs to detect SHA tests that are incorrectly configured for BIT oriented implementations

Status: RESOLVED FIXED

(NSS :: Tools, enhancement)

Description

[Wan-Teh Chang]

The sha_test function in the fipstest test program needs
to detect SHA tests that are incorrectly configured for
BIT oriented implementations.  NSS is a BYTE oriented
implementation.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

The message lengths are in bits.  For a BYTE oriented
implementation, the message lengths are multiples of 8.
For a BIT oriented implementation, the message lengths
can be any integers.

So we fail with an error message (to stderr) if we see
a message length that's not a multiple of 8.

Comment 2

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (NSS 3.12).

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.31; previous revision: 1.30
done

Comment 3

[Neil Williams]

Comment on attachment 240364 [details] [diff] [review]
Proposed patch

Shouldn't the message be "tests are incorrectly configured..."?

Comment 4

[Wan-Teh Chang]

Neil, I made the change you suggested.  Thanks!

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.32; previous revision: 1.31
done