355037 - drag a file with a .URL extension.

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[7leonn]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.7) Gecko/20060911 Camino/1.0.3 (MultiLang)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.7) Gecko/20060911 Camino/1.0.3 (MultiLang)

I drag this link on camino, and it downloads itself (the .URL bookmark) again and again. Camino is unusable ans my downloads folder is overhelmed with this auto-duplicating file. Safari does well with the .URL bookmark.

Reproducible: Always

Steps to Reproduce:
1.drag the .URL to camino
2.Let it bug
3.Force to quit



Expected Results:  
open the embedded url of the .URL file

I wish I could upload you a .URL bookmark for you to investigate on this issue.

Comment 1

[7leonn]

the .URL file, opened with textedit is (for example):
[InternetShortcut]

URL=http://www.laserpod.com/introduction.asp

and the filename (open with camino by default)is:
laserpod.URL

Comment 2

[Wevah (Nate Weaver)]

Change the extension from .URL to .url and it will work. However, I should probably make the extension check case-insensitive. Taking.

Comment 3

[Wevah (Nate Weaver)]

Attachment: The fix.

The fix is to lowercase the file extension before the isEqualToString: calls.

Comment 4

[Wevah (Nate Weaver)]

Severity -> normal.

I don't see any auto-duplication, and the fix is trivial, so...

Comment 5

[Wevah (Nate Weaver)]

Attachment: The fix, v2.

Oops, I missed the one in MainController.mm.

Comment 6

[Wevah (Nate Weaver)]

Attachment: -u version of v2.

r+ as per froodian on IRC.

Comment 7

[Wevah (Nate Weaver)]

Attachment: v3: Add BookmarkManager.mm, too.

Fixing up the BM manager too, so we don't have to worry about it later (per smorgan).

Comment 8

[Stuart Morgan]

Comment on attachment 240841 [details] [diff] [review]
v3: Add BookmarkManager.mm, too.

r=me

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This looks simple enough to consider for 1.0.4 when the time comes.

Comment 10

[froodian (Ian Leue)]

Checked in on trunk and 1.8branch

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This patch fails to apply on the 1.8.0 branch.  

If someone whips up a 180branch-compatible patch, we'll consider this for 1.0.4.

Comment 12

[Wevah (Nate Weaver)]

I'll have to check out that branch, but I should be able to do it.

Comment 13

[Wevah (Nate Weaver)]

Attachment: Patch for 1.8.0 branch

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 248433 [details] [diff] [review]
Patch for 1.8.0 branch

I tested this, and it works as expected (within the confines of bug 363654 on the 1.8.0 branch and bug 363633 everywhere).

Comment 15

[froodian (Ian Leue)]

Comment on attachment 248433 [details] [diff] [review]
Patch for 1.8.0 branch

r=me.  Since the differences are redonkulous, foregoing a second sr.  If anybody disagrees, they should speak up before I get to checkins.

Comment 16

[froodian (Ian Leue)]

Checked in on 1.8.0branch (forgot bug number in checkin comment, search for "robustification")