355608 - xulrunner + python fails with "dist/lib/libpyxpcom.a: No such file or directory"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When I try to compile xulrunner with the python extension enabled, the build dies with the following error:

---
gmake[7]: Entering directory `/home/myk/Projects/pyxulrunner/mozilla/obj-xulrunner/extensions/python/dom/src'
rm -f libpydom.so
c++  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O -DPYTHON_SO=\"libpython2.4.so\" -fPIC -shared -Wl,-z,defs -Wl,-h,libpydom.so -o libpydom.so  nsPyArgArray.o nsPyContext.o nsPyRuntime.o nsPyDOMModule.o nsPyDOMISupports.o nsPyTimeout.o    -lpthread    -L../../../../dist/bin -Wl,-rpath-link,../../../../dist/bin -lxpcom -lxul  -L../../../../dist/bin -L../../../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl ../../../../dist/lib/libxpcomglue_s.a -L../../../../dist/bin -Wl,-rpath-link,../../../../dist/bin -lxpcom  -Wl,--version-script -Wl,/home/myk/Projects/pyxulrunner/mozilla/build/unix/gnu-ld-scripts/components-version-script -Wl,-Bsymbolic -ldl -lm  -L/usr/lib -lpython2.4 -lutil ../../../../dist/lib/libpyxpcom.a  -L../../../../dist/bin -lmozjs
c++: ../../../../dist/lib/libpyxpcom.a: No such file or directory
gmake[7]: *** [libpydom.so] Error 1
gmake[7]: Leaving directory `/home/myk/Projects/pyxulrunner/mozilla/obj-xulrunner/extensions/python/dom/src'
---

Symlinking libpyxpcom.a to libpyxpcom.so seems to work around the problem.

Comment 1

[Alex Badea]

Attachment: patch to use .so suffix instead of .a

This fixes it for me (linux, gcc 4.1.2). Not tested on other platforms.

Comment 2

[Shane Caraveo]

bug 375318 for general pyxpcom/xulrunner/cvs trunk build issues

Comment 3

[Marco Pesenti Gritti]

Alex, I have no idea if the fix is correct but it seem to work for me (linux). It would be good to ask review for it so that we can get a fix for this issue on the trunk.

Comment 4

[Klaus Nowikow]

I've been using xulrunner with pyxpcom for a couple of weeks now, with this patch, and it seems to work for me, too (Ubuntu edgy, gcc 4.1.2).

Comment 5

[Alexander Sack]

Comment on attachment 253079 [details] [diff] [review]
patch to use .so suffix instead of .a

libpyxpcom is currently build as shared library.

Thus, this patch looks reasonable.

Benjamin, do you still consider patches and do reviews for python?

Comment 6

[Benjamin Smedberg]

Comment on attachment 253079 [details] [diff] [review]
patch to use .so suffix instead of .a

normally no, but this looks pretty obvious

Comment 7

[Benjamin Smedberg]

Comment on attachment 253079 [details] [diff] [review]
patch to use .so suffix instead of .a

Actually, this will break Windows.

You want $(call EXPAND_LIBNAME_PATH,pyxpcom,$(DIST)/lib)

Comment 8

[Alex Badea]

Attachment: patch to use EXPAND_LIBNAME_PATH

Changed as suggested; verified to build on Linux and win32.

Comment 9

[Benjamin Smedberg]

Comment on attachment 284153 [details] [diff] [review]
patch to use EXPAND_LIBNAME_PATH

This doesn't need approval, it's NPOB

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

given the NPOB from bsmedberg and the r+, asking for checkin

Comment 11

[Reed Loden [:reed]]

Checking in extensions/python/dom/src/Makefile.in;
/cvsroot/mozilla/extensions/python/dom/src/Makefile.in,v  <--  Makefile.in
new revision: 1.4; previous revision: 1.3
done