355632 - unable to make tbird on the Mac my default news:// reader

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[(not reading, please use [e-mail] instead)]

unable to make tbird on the Mac my default news:// reader

note: the corresponding pref UI (for making it the default mail/news/rss reader) differs between Mac and Windows tbird, too.

on mac, all I can do is make tbird my default mail reader.

Comment 1

[(not reading, please use [e-mail] instead)]

note, I'm using version 2 beta 1 (20061005) on mac os x

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

This appears to still be true on the trunk.

Comment 3

[Phil Ringnalda (:philor)]

Curiously enough, I can't make it *not* my default news reader:

Prefs - General, check on startup is checked, I click the Check Now button, and along with yet another checkbox for check on startup that shouldn't be there, I have default email and default news checked and disabled, and only RSS unchecked and enabled.

Comment 4

[Phil Ringnalda (:philor)]

I guess it's worth noting that whether or not you successfully set it as default, it's not going to actually work. Toolkit's Mac commandline handling is broken: if the app isn't running, it calls commandline handlers, but if it is running it just passes the commandline to browser.chromeURL. In our case that's the chrome URL for the compose window, so that at least mailto works, but things like RSS subscription don't, and can't until we either rewrite toolkit's commandline handling, or give the hidden window a dispatcher that either duplicates or runs commandline handlers while we're open.

Comment 5

[Magnus Melin [:mkmelin]]

Comment 3 is bug 360809.

Comment 6

[David :Bienvenu]

not going to block on a news + mac bug

Comment 7

[Ludovic Hirlimann [:Usul]]

Attachment: [checked in] Could this be the fix ?

How should one write a test for that ?

Comment 8

[David :Bienvenu]

that certainly looks like a possible fix. Does it work?

I don't know how one would write a test for that.

Comment 9

[Ludovic Hirlimann [:Usul]]

(In reply to comment #8)
> that certainly looks like a possible fix. Does it work?
> 

Untested - I'll build over the week-end and see if that does the trick.

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to comment #9)
> (In reply to comment #8)
> > that certainly looks like a possible fix. Does it work?
> > 
> 
> Untested - I'll build over the week-end and see if that does the trick.

Actaully just launched try builds.

Comment 11

[Ludovic Hirlimann [:Usul]]

(In reply to comment #8)
> that certainly looks like a possible fix. Does it work?

Yes it works.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 426674 [details] [diff] [review]
[checked in] Could this be the fix ?

Yep, this fixes it so that it doesn't depend on the RSS option.

I don't see an easy automated test for this, especially as it would require changing system defaults and interactions with other apps. Therefore waiving the test requirement.

Checked in:
http://hg.mozilla.org/comm-central/rev/705fcc83a092