355947 - Command+click on a link on Yahoo! opens a new tab in Safari, why not Camino?

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Mike]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.7) Gecko/20060911 Camino/1.0.3
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.7) Gecko/20060911 Camino/1.0.3

I read your response to other users' complaints regarding Camino's inability to open a Yahoo.com link in a new tab with Command+click, stating it was Yahoo's fault and invalid.  Safari has no problem doing this, however...   Why the disparity?

Reproducible: Always



Expected Results:  
Work as well as Safari.

Comment 1

[Håkan Waara]

Can you give full information in this bug? Which link should I click to see the bug?

Comment 2

[froodian (Ian Leue)]

A link to this response would be nice too.

Comment 3

[philippe (part-time)]

Assuming the new Y! layout.
Applies to *any* link on that page.
Fails in Camino trunk, Firefox 2.0 RC2 and recent Minefield.
(and Fx 2.0RC2 spoofed as Fx 1.5).

Apparently some JS is catching the command+click event.
Middle-click works correctly (my mouse is set for it).

Apart from a few zillion of css errors, the Fx Error-Console doesn't report anything wrong.

Comment 4

[Chris Lawson (gone)]

(In reply to comment #3)
> Assuming the new Y! layout.
> Applies to *any* link on that page.
> Fails in Camino trunk, Firefox 2.0 RC2 and recent Minefield.
> (and Fx 2.0RC2 spoofed as Fx 1.5).

Absent any other information, the above sure sounds like Tech Evangelism to me.

Comment 5

[philippe (part-time)]

(In reply to comment #4)
> Absent any other information, the above sure sounds like Tech Evangelism to me.
> 

It _could_ be a bug in Gecko's JS handling. As you can see from the source code, there is lots of JS in there, and it is not the most easy to read. Any JS specialist in the house ?

So far I've narrowed it down to this:
http://us.js2.yimg.com/us.js.yimg.com/i/ww/sp/js_1.9.14.js
Delete that _linked_ script, and command clicking on links works.
Have fun to debug that one.
(saving the page locally, and deleting things from the bottom upwards).

Comment 6

[philippe (part-time)]

Attachment: testcase

One link on the page, and the script mentioned in comment 5 linked.
Command click fails.

BTW this works as expected in Safari 2.0 and latest Webkit nightly. It works correctly in Opera 9.02.

Comment 7

[Torben]

> One link on the page, and the script mentioned in comment 5 linked.
> Command click fails.

Commenting out line 197 (the line starting with var sUrl='http:) from the script will make the Cmd-click work.

Comment 8

[Stuart Morgan]

(In reply to comment #3)
> Fails in Camino trunk, Firefox 2.0 RC2 and recent Minefield.
> (and Fx 2.0RC2 spoofed as Fx 1.5).

-> Core

Comment 9

[Brendan Eich [:brendan]]

That's not a reduced testcase -- http://us.js2.yimg.com/us.js.yimg.com/i/ww/sp/js_1.9.14.js needs to be reduced.

Bugs like this should be left in a general component, not reassigned to the JS engine, unless there is specific evidence implicating the JS engine.  There is no such evidence yet.

/be

Comment 10

[Samuel Sidler (old account; do not CC)]

Does this happen on the 1.8.0 branch?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 241692 [details]
testcase

Ctrl+Click works for me, in recent 1.8 branch and trunk Firefox builds on Windows. I can't reduce a testcase for something I can't reproduce :)

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Though if you can confirm that this bug is Mac specific, I can probably borrow a mac for long enough to debug a bit. If this is a regression, finding a narrow regression range would be ideal. Otherwise, I suspect this is an issue with the site's JavaScript, and not with Gecko.

Comment 13

[Torben]

> Does this happen on the 1.8.0 branch?

Yes, tested with Camino 1.0.3

Comment 14

[Samuel Sidler (old account; do not CC)]

(In reply to comment #12)
> Though if you can confirm that this bug is Mac specific, I can probably borrow
> a mac for long enough to debug a bit. If this is a regression, finding a narrow
> regression range would be ideal. Otherwise, I suspect this is an issue with the
> site's JavaScript, and not with Gecko.

I can confirm that I see this bug in Fx2 RC2 on Mac, but not Fx2 RC2 on Windows. (I haven't checked Linux, however.)

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Does still not work with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090413 Shiretoko/3.5b4pre ID:20090413031313

Martijn, is there an easy way to reduce this huge js file?

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ah, and there is one error shown in the Error Console:

Error: YAHOO is not defined
Source File: http://us.js2.yimg.com/us.js.yimg.com/i/ww/sp/js_1.9.14.js
Line: 72

Comment 17

[Simona Badau, Desktop QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0
Build ID: 20130805030205

I can't reproduce this issue on the latest Nightly. Setting the status of this issue to Resolved Worksforme. If anyone else is still able to reproduce this issue, please reopen.