356294 - Enable MSAA-only code only on windows

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Håkan Waara]

There's some code that relies on the fact that #ifndef MOZ_ACCESSIBILITY_ATK is the same as being on Windows. This is not the fact anymore...

Comment 1

[Håkan Waara]

Attachment: Patch for caret code (checked in)

I'll keep this bug open for other instances where we have to make code XP_WIN-only (I don't want to do a mass-change before I know what the change in behavior would be).

Here's a fix to only enable some caret notification code on windows, and let ATK/mac share the other code.

Comment 2

[Håkan Waara]

Comment on attachment 241967 [details] [diff] [review]
Patch for caret code (checked in)

I've checked this in. I'll keep this bug open in case there will be other patches where we'll have to remove ATK #ifndefs to XP_WIN

Comment 3

[Eitan Isaacson [:eeejay]]

I took a look, and there are no more places where this pattern occurs. There still are platform ifdefs in the base code but they all seem sensible and they don't imply a platform by negation.