356959 - Update window title and tab label

Status: RESOLVED FIXED

(Composer Graveyard :: Tabs, enhancement)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Update window title and tab label on document load and tab select.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 2

[Kathleen :Brade]

Comment on attachment 242494 [details] [diff] [review]
fix #1

I'm ok with most of the patch.  The only thing I see is that the window title and doc title could use format strings instead of hard coding this format.  Right-To-Left languages may want to reorder the components of the window title.  In the past, I've added something like "Last modified %1$S by %s$S" to the appropriate properties file.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #2 in answer to brade's comments

Comment 4

[Kathleen :Brade]

Comment on attachment 242751 [details] [diff] [review]
fix #2 in answer to brade's comments

r=brade if you switch to using stringBundle.formatStringFromName() with properties that use %1$S.

In RTL languages are urls still shown LTR? (Is the scheme on the left or the right?)

Please post final patch in bug.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #3 holding r=brade

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

fixed and checked in (trunk) ; thanks brade!