357389 - Show ID/classes in structure toolbar and allow to select element

Status: RESOLVED FIXED

(Composer Graveyard :: General, enhancement)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

The structure toolbar should show when an element carries an ID or classes.
It should also allow to select an element clicking on its entry in the
structure toolbar.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: mucho better, fix #2

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 242861 [details] [diff] [review]
mucho better, fix #2

Kathy, can you review that one too ?

Comment 4

[Alex Vincent [:WeirdAl]]

Comment on attachment 242861 [details] [diff] [review]
mucho better, fix #2

>+            newLabel.setAttribute("oncommand", "this.parentNode.selectNode(this)");

I have to really wonder about this.  Why can't you set a capturing or bubbling event listener on this (in a <handler> element on the binding)?  event.target would reflect the newLabel object, I'm pretty sure, and event.currentTarget == this.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

fixed and checked in (trunk)

Comment 6

[Paul Rouget [:paul]]

(In reply to comment #5)
> fixed and checked in (trunk)
> 

And where is dummyCommands.inc ?

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

/me sends tortoiseCVS to /dev/null, second time it misses a cvs-added file in a week. Thanks paul, fixed.