357634 - Problem files in CVS, state is dead and file not in Attic

Status: RESOLVED WONTFIX

(mozilla.org :: CVS: Administration, task, P3)

Description

[Jon Smirl]

I ran the validate_repo.pl tool that comes with CVS (may be a gz file) over a rsync of Mozilla CVS I have locally. It reports 132 corrupted files in the repo. They are all being reported corrupted for the same reason (I think I checked all 132 errors).

 `mozilla/content/html/style/src/nsRuleNode.cpp' is corrupted. It is NOT in the Attic and contains a dead head revision

If you look inside mozilla/content/html/style/src/nsRuleNode.cpp,v you'll see that the head version is indeed marked dead.

3.24
date    2001.10.24.00.00.11;    author hyatt%netscape.com;      state dead;
branches;
next    3.23;

When you CVS rm a file it gets marked dead and moved into the attic. These files are marked dead but they are not in the attic. I don't know how these files got into this state unless someone manually moved them out of the attic. 

A decision needs to be made for each of these files. If they really are deleted they should be moved to the attic. If they are not deleted (someone moved them out of the Attic to recover them) then their state should be changed from dead to Exp.

Here is the complete list I got from validate_repo.pl

List of corrupted files
**** File: mozilla/widget/public/nsIWindow.idl
**** File: mozilla/content/html/style/src/nsRuleNode.cpp
**** File: mozilla/include/cgi.h
**** File: mozilla/cmd/xfe/icons/anim/main/AnimSm33.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimSm31.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimHuge31.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimHuge30.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimSm32.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimSm30.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimHuge34.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimHuge33.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimSm34.gif
**** File: mozilla/cmd/xfe/icons/anim/main/AnimHuge32.gif
**** File: mozilla/cmd/xfe/src/FrameListMenu.h
**** File: mozilla/cmd/xfe/src/FrameListMenu.cpp
**** File: mozilla/lib/libnet/mkmemcac.c
**** File: mozilla/lib/libnet/mkgopher.h
**** File: mozilla/lib/libnet/mkftp.h
**** File: mozilla/lib/libnet/crawler.h
**** File: mozilla/lib/libnet/htmparse.h
**** File: mozilla/lib/libnet/mkpadpac.c
**** File: mozilla/lib/libnet/cvextcon.c
**** File: mozilla/lib/libnet/cvsimple.h
**** File: mozilla/lib/libnet/mkpop3.c
**** File: mozilla/lib/libnet/mkdaturl.c
**** File: mozilla/lib/libnet/mkconect.c
**** File: mozilla/lib/libnet/mkstream.c
**** File: mozilla/lib/libnet/cvview.h
**** File: mozilla/lib/libnet/mknews.c
**** File: mozilla/lib/libnet/extcache.c
**** File: mozilla/lib/libnet/mkgeturl.c
**** File: mozilla/lib/libnet/mkpadpac.h
**** File: mozilla/lib/libnet/mkformat.c
**** File: mozilla/lib/libnet/jscookie.c
**** File: mozilla/lib/libnet/prefetch.c
**** File: mozilla/lib/libnet/mkparse.h
**** File: mozilla/lib/libnet/mkfsort.h
**** File: mozilla/lib/libnet/mktcp.h
**** File: mozilla/lib/libnet/mkselect.c
**** File: mozilla/lib/libnet/cvdisk.h
**** File: mozilla/lib/libnet/mkalert.c
**** File: mozilla/lib/libnet/mkremote.c
**** File: mozilla/lib/libnet/mkjscfg.h
**** File: mozilla/lib/libnet/mkstream.h
**** File: mozilla/lib/libnet/Makefile
**** File: mozilla/lib/libnet/mkmailbx.h
**** File: mozilla/lib/libnet/txview.h
**** File: mozilla/lib/libnet/cvmime.c
**** File: mozilla/lib/libnet/mkmocha.c
**** File: mozilla/lib/libnet/mkpop3.h
**** File: mozilla/lib/libnet/mkcertld.c
**** File: mozilla/lib/libnet/mkinit.c
**** File: mozilla/lib/libnet/mkdaturl.h
**** File: mozilla/lib/libnet/mkformat.h
**** File: mozilla/lib/libnet/mkutils.h
**** File: mozilla/lib/libnet/mime.types-nonunix
**** File: mozilla/lib/libnet/pagescan.c
**** File: mozilla/lib/libnet/mkmarimb.cpp
**** File: mozilla/lib/libnet/mkhttp.h
**** File: mozilla/lib/libnet/robotxt.h
**** File: mozilla/lib/libnet/mknewsgr.c
**** File: mozilla/lib/libnet/jsautocf.h
**** File: mozilla/lib/libnet/mksmtp.h
**** File: mozilla/lib/libnet/mktrace.c
**** File: mozilla/lib/libnet/mkfile.h
**** File: mozilla/lib/libnet/mkhttp.c
**** File: mozilla/lib/libnet/jscookie.h
**** File: mozilla/lib/libnet/mkautocf.c
**** File: mozilla/lib/libnet/mkextcac.c
**** File: mozilla/lib/libnet/mkhelp.h
**** File: mozilla/lib/libnet/cvmime.h
**** File: mozilla/lib/libnet/mkcache.h
**** File: mozilla/lib/libnet/mkjscfg.c
**** File: mozilla/lib/libnet/mkgopher.c
**** File: mozilla/lib/libnet/mkmessag.c
**** File: mozilla/lib/libnet/jsautocf.c
**** File: mozilla/lib/libnet/cvunzip.h
**** File: mozilla/lib/libnet/htmparse.c
**** File: mozilla/lib/libnet/cvchunk.c
**** File: mozilla/lib/libnet/mkabook.cpp
**** File: mozilla/lib/libnet/cvcolor.c
**** File: mozilla/lib/libnet/mkcache.c
**** File: mozilla/lib/libnet/pagescan.h
**** File: mozilla/lib/libnet/cvpics.h
**** File: mozilla/lib/libnet/mkhelp.c
**** File: mozilla/lib/libnet/cvdisk.c
**** File: mozilla/lib/libnet/unix-dns.c
**** File: mozilla/lib/libnet/mktrace.h
**** File: mozilla/lib/libnet/cvextcon.h
**** File: mozilla/lib/libnet/mksort.h
**** File: mozilla/lib/libnet/extcache.h
**** File: mozilla/lib/libnet/mkmemcac.h
**** File: mozilla/lib/libnet/cvpics.c
**** File: mozilla/lib/libnet/cvcolor.h
**** File: mozilla/lib/libnet/cvunzip.c
**** File: mozilla/lib/libnet/cvchunk.h
**** File: mozilla/lib/libnet/mknews.h
**** File: mozilla/lib/libnet/cvproxy.h
**** File: mozilla/lib/libnet/mkautocf.h
**** File: mozilla/lib/libnet/txview.c
**** File: mozilla/lib/libnet/cvsimple.c
**** File: mozilla/lib/libnet/mksockrw.c
**** File: mozilla/lib/libnet/mkutils.c
**** File: mozilla/lib/libnet/mkparse.c
**** File: mozilla/lib/libnet/mkcertld.h
**** File: mozilla/lib/libnet/mkaccess.c
**** File: mozilla/lib/libnet/cvactive.c
**** File: mozilla/lib/libnet/mktypes.h
**** File: mozilla/lib/libnet/mkmailbx.c
**** File: mozilla/lib/libnet/mkgeturl.h
**** File: mozilla/lib/libnet/mknewsgr.h
**** File: mozilla/lib/libnet/mkfsort.c
**** File: mozilla/lib/libnet/mkmarimb.h
**** File: mozilla/lib/libnet/mkftp.c
**** File: mozilla/lib/libnet/mksort.c
**** File: mozilla/lib/libnet/robotxt.c
**** File: mozilla/lib/libnet/bombdate.tcl
**** File: mozilla/lib/libnet/cvview.c
**** File: mozilla/lib/libnet/mkmocha.h
**** File: mozilla/lib/libnet/mkextcac.h
**** File: mozilla/lib/libnet/mime.types
**** File: mozilla/lib/libnet/cachedump.c
**** File: mozilla/lib/libnet/mkldap.h
**** File: mozilla/lib/libnet/mkabook.h
**** File: mozilla/lib/libnet/mkfile.c
**** File: mozilla/lib/libnet/mime.types-unix
**** File: mozilla/lib/libnet/cvproxy.c
**** File: mozilla/lib/libnet/mkselect.h
**** File: mozilla/lib/libnet/mkremote.h
**** File: mozilla/lib/libnet/mksmtp.c
**** File: mozilla/lib/libnet/crawler.c
**** File: mozilla/lib/libnet/mkaccess.h

Comment 1

[Dave Miller [:justdave]]

I'll be happy to move the files, but I'm not going to do it without someone validating it won't break things...

Comment 2

[timeless]

cmd/xfe and lib/libnet are from classic. attic them.
include/ was supposed to be attic as well, attic include/cgi.h

mozilla/widget/public/nsIWindow.idl looks like it didn't want to be on HEAD, i'd move it, feel free to ask pavlov if you're feeling timid.

the current live nsRuleNode.cpp is mozilla/layout/style/nsRuleNode.cpp

any other belongs in attic. make them so, let them rest in peace.

Comment 3

[Dave Miller [:justdave]]

Comment 2 suggests pavlov might know something about these...  :)

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Found during Build&Release bug triage, reassiging to cvs:admin. 

Comment 5

[Dave Miller [:justdave]]

This was given to build because someone who knows the state of the code needs to sign off on how to fix each file.  Some of them may need special handling, and there's a chance of dataloss if we just go randomly moving the files around.  Perhaps it needs to go to the module owners of the affected modules...

Comment 6

[Stuart Parmenter]

nsIWindow.idl was probably done on a branch and then later used on head.. not sure though.

Comment 7

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #5)
> This was given to build because someone who knows the state of the code needs
> to sign off on how to fix each file.  Some of them may need special handling,
> and there's a chance of dataloss if we just go randomly moving the files
> around.  Perhaps it needs to go to the module owners of the affected modules...
> 
The module owners definitely know those files better then the Build&Release team, so yep, I agree, the module owners should be asked what to do here. 

Let us know if there is anything Build can do to help.

Comment 8

[Dave Miller [:justdave]]

OK, so what needs to happen here is we need to split this up by module and probably file a separate bug for each module's worth of files, and assign it to the module owner to sign off on and decide what to do within his/her module.

Comment 9

[Dave Miller [:justdave]]

>List of corrupted files
>**** File: mozilla/widget/public/nsIWindow.idl

The above file is part of the Widget module, which is owned by roc.

Everything else on the list is not part of any module and unowned.  Shaver said to assign to him and CC brendan (already CCed), so doing so.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm not sure what's being asked. I don't know where nsIWindow came from, what it's for, or what we should do with it. Since we obviously don't use it, I don't really care either.

Comment 11

[Dave Miller [:justdave]]

So it turns out this is a lot of unowned code.  Unless anyone objects, shall we go ahead with timeless' plan from comment 2?

Comment 12

[Brendan Eich [:brendan]]

(In reply to comment #11)
> So it turns out this is a lot of unowned code.  Unless anyone objects, shall we
> go ahead with timeless' plan from comment 2?

Absolutely.

What else is left in include that is in use by some official project? I'm asking whether there is anything left to "attic" in include.

/be

Comment 13

[Jeremy Orem [:oremj]]

Changing QA Contact.

Comment 14

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Whose FIX? WONTFIX!