357898 - Migration fails to fire on launch if the previous system default browser is Opera

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Tracy Walker [:tracy]]

Seen on 2.0 and 1.5.0.8 candidate builds.

steps to reproduce:
-remove/rename Firefox profile folder
-Run Seamonkey or Opera and set it as the default browser
-Launch Firefox

Tested results:
Firefox launches bypassing the Migration Wizard

expected results:
The Migration Wizard appears then Firefox launches when the wizard is dismissed

note: If IE or Firefox was previously set as the default browser, then the Migration wizard appears as expected.

I have a feeling this has been around a while. juanb filed a similar bug back in August, but then invalidated it when he couldn't immediately reproduce.  (Firefox was then probably the default on his retries) I'll start my search for the regression window around then

Comment 1

[Tracy Walker [:tracy]]

nominating for the next set of point releases.

Comment 2

[Tracy Walker [:tracy]]

removing regression keyword. 

I tested back to 1.5 release; it is affected by this bug.  I checked another theory as to why I hadn't seen this before.  Basically I've never set Opera as my default, so wouldn't have caught it from there. Until just recently I had been using Mozilla 1.7.13 as my default browser.  Mozilla builds also don't cause this bug.  So it's just Seamonkey and Opera.

So why does Firefox fail to launch migration after either of those browsers was set as default?

Comment 3

[Daniel Veditz [:dveditz]]

Not blocking 1.8.1.1 if IE works, but would like this looked at.

mconnor: is there a good assignee for this one?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

So I looked into this a little bit, and found several bugs:
1) On the trunk, profile migration is busted in all cases due to the patch for bug 345517. I filed bug 364042 for this.
2) Opera's installer puts bogus data into the registry, which makes our registry reading code barf (it inserts an extra byte after the null-terminated string, which makes the check at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/ds/nsWindowsRegKey.cpp&rev=1.6#439 fail). I've reported this bug to Opera, I don't know whether we want to work around it or not. I think I'll morph this bug to cover that issue.
3) SeaMonkey (as of Seamonkey 1.0) now uses an internal name of "SeaMonkey" rather than "apprunner", so we fail to detect those versions as valid default browsers. That means that the profile migration doesn't show up when SeaMonkey is the default browser. I filed bug 364041 for that.

Even after I fix bug 364041 locally, SeaMonkey isn't listed as an option in the dialog. That's probably a separate bug that I'll look into once bug 364041 is fixed.

Comment 5

[Tracy Walker [:tracy]]

This remains broken in Fx3b2 and latest Minefield nightly builds.  However, it appears to be a larger problem. I can set default to IE7, Fx2.0.0.11, Opera or even Mozilla1.8, but when I try migration on fresh install of the trunk based builds I get no migration dialog.

I can get migration to fire from 2.0.0.11 if I clean up everything (including reg keys)

I'm concerned my system is horked though.

Comment 6

[Mike Connor [:mconnor]]

Tracy, if there's any profile data at all we won't prompt to migrate on first run.  You need to nuke all of %appdata%/Mozilla/Firefox to get this to run, by design.

The specific issue with Opera here doesn't block, its not a regression and its very late in the cycle to muck with the migration code.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I reported the bug to Opera a while ago, but I don't think they have any way to followup. Need to test to see whether this is still an issue, I guess.

Comment 8

[Asaf Romano (gone)]

No Opera migrator available now, and the other issue discussed here is fixed by the migrators-fallback-list in ProfileMigraotr.js (to be moved to MigrationUtils.jsm soon).

Comment 9

[Claudio McCawley]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #4)

So I looked into this a little bit, and found several bugs:

1. On the trunk, profile migration is busted in all cases due to the patch
   for bug 345517. I filed bug 364042 for this.
2. Opera's installer puts bogus data into the registry, which makes our
   registry reading code barf (it inserts an extra byte after the
   null-terminated string, which makes the check at
   http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/ds/nsWindowsRegKey.
   cpp&rev=1.6#439 fail). I've reported this bug to Opera, I don't know whether
   we want to work around it or not. I think I'll morph this bug to cover that
   issue.https://4kpornindex.com/tt/388099612funnygifs432455611.gif
3. SeaMonkey (as of Seamonkey 1.0) now uses an internal name of "SeaMonkey"
   rather than "apprunner", so we fail to detect those versions as valid
   default browsers. That means that the profile migration doesn't show up when
   SeaMonkey is the default browser. I filed bug 364041 for that.

Even after I fix bug 364041 locally, SeaMonkey isn't listed as an option in
the dialog. That's probably a separate bug that I'll look into once bug
364041 is fixed.

thx is fixed