358553 - Disabled and checked menuitems should always have disabled checkmarks

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

Spun-off from bug 345252. If you hover over a checked menuitem that is disabled you shouldn't see any hover effect on the checkmark.

Comment 1

[Stefan [:stefanh]]

Hmm... I went ahead and did a patch, but then I looked at the tick/radio marks. They're the same for normal and disabled state (Modern and classic/win). Wouldn't it look odd if you just fix the css and not the icons?

Comment 2

[[e-mail]]

I don't have Modern handy but I agree it's incorrect in Classic.

Still, changing the colour is easy enough.

Comment 3

[Stefan [:stefanh]]

Attachment: flip style rules

This should fix classic. I'll attach new icons in a few sec.

Comment 4

[Stefan [:stefanh]]

Attachment: New menu-check-disabled.gif

Comment 5

[Stefan [:stefanh]]

Attachment: New menu-radio-disabled.gif

Comment 6

[Stefan [:stefanh]]

Attachment: New menu-arrow-disabled.gif

I changed color of menu-arrow-disabled.gif (old one had a0a0a0). Note that the patch and the icons are not tested...

Comment 7

[[e-mail]]

(In reply to comment #6)
>I changed color of menu-arrow-disabled.gif (old one had a0a0a0).
Hmm, I found some of our disabled arrows use #999999 ...

Manuel, what's your preference?

Comment 8

[[e-mail]]

Sigh, the so-called disabled check mark is black :-(

Comment 9

[[e-mail]]

So, we currently have:
generic arrow images: disabled colour #999999
checkbox/radiobutton images: disabled colour #808080
menu right arrow: disabled colour #a0a0a0
menu check/radio images: disabled colour #000000
So the menu images are at least definitely wrong ;-)

Comment 10

[Stefan [:stefanh]]

(In reply to comment #9)
> So, we currently have:
> generic arrow images: disabled colour #999999
> checkbox/radiobutton images: disabled colour #808080
> menu right arrow: disabled colour #a0a0a0
> menu check/radio images: disabled colour #000000
> So the menu images are at least definitely wrong ;-)
> 
Do you want to go with the 3 disabled images with colour #808080 that I've attached?

Comment 11

[Stefan [:stefanh]]

Comment on attachment 244479 [details] [diff] [review]
flip style rules

This is just a style-rule flip that makes us use the css for disabled checkmarks when you hover over a disabled and checked menuitem. We need the images as well (if we want the change to mean anything).

Comment 12

[Robert Kaiser]

Comment on attachment 244479 [details] [diff] [review]
flip style rules

first-a=me for SeaMonkey 1.1

Comment 13

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Has this baked on trunk?

Comment 14

[Stefan [:stefanh]]

(In reply to comment #13)
> Has this baked on trunk?

No it hasn't - I forgot to ask someone to check it in :-/

Comment 15

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Landing this on trunk so I can grant approval for branch soon.

Comment 16

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checked in new images too.

Comment 17

[Stefan [:stefanh]]

Chris, can you land it on branch please?

Comment 18

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Verified on trunk.
Checked in on branch.