358558 - R_386_PC32 relocations in libtracemalloc.so when building on FC6

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When building on Fedora Core 6 (where our system wrappers stuff works, and where the big gcc visibility bug is fixed), SELinux prevents me from starting due to the bad type of relocations in libtracemalloc.so and libxul.so.  This bug covers the problem in libtracemalloc.so.

The problem there is that we manually declare a bunch of __libc_* functions without going through the visibility-wrapping that we do for all other system headers.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 243932 [details] [diff] [review]
patch

This is a very low risk patch that will, along with the patches to bug 358559 and bug 358565:
 * make it easier for developers to build on new distributions like Fedora Core 6

It's also not part of code that we ship -- it's in a debugging tool.

Comment 4

[Daniel Veditz [:dveditz]]

Can't see how we can call this a "blocker", but looks like goodness.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 243932 [details] [diff] [review]
patch

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.