358560 - Canvas2D renders black with 16M colors on OS/2

Status: VERIFIED FIXED

(Core Graveyard :: GFX: OS/2, defect)

Description

[Peter Weilbacher]

As noted in the newsgroup the canvas that is created by the Firefox Showcase extension or the SeaMonkey tab preview tooltips displays black when the system is set to 16M colors with the SNAP driver. With the 64K colors setting it displays just fine.

Comment 1

[Peter Weilbacher]

Attachment: add pixel format for BGR_A8

The problem is simply because nsOffscreenSurface::GetPixelFormat() does not implement 32bit depths, just 24bit depth. I don't know why SNAP implements 16M colors as 32bit instead of 24bit but this patch seems to fix the problem here. It implements 32bit as BGR_A8 which is what OS/2+SNAP seems to be using (at least that is the format that always worked in the SVG code). It uses basically the same bit masks as GetPixelFormat() on Windows.

Andy, would be great if you could confirm that this patch fixes the problem for you, too.

Comment 2

[Andy Willis (abwillis)]

Comment on attachment 243934 [details] [diff] [review]
add pixel format for BGR_A8

Works like a charm.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 243934 [details] [diff] [review]
add pixel format for BGR_A8

sr=mkaply (OS2 only)

Comment 4

[Peter Weilbacher]

Fix checked into trunk (with an additional "break;" that was missing from the patch).

Comment 5

[Peter Weilbacher]

Comment on attachment 243934 [details] [diff] [review]
add pixel format for BGR_A8

Would be great to get this OS/2 only, trunk tested fix into 1.8 branch.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 243934 [details] [diff] [review]
add pixel format for BGR_A8

approved for 1.8 branch, a=dveditz for drivers

Comment 7

[Peter Weilbacher]

Verifying some older bugs.