358701 - Week(Multiday)view: vertical day/date header column too wide, could be much narrower

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061029 Calendar/0.4a1

When week view times are on the horizontal x axis, the day headers are listed vertically in the left column, but arranged using space inefficiently.
 

Reproducible: Always

Steps to Reproduce:
1. View week view
2. transpose so dates and day names are in left column, times across the top.


Actual Results:  
 The date and weekday name are arranged horizontally, so left column is much 
    wider than necessary, wasting a large space below each pair.
  The space for all-day events is too narrow, so only a few letters 
    of the title are visible.

Expected Results:  
 Date and week day names arranged vertically.
 Wider space for all-day events, similar to an hour.

Comment 1

[gekacheka]

Attachment: Patch: use vertical boxes for day labels, widen all-day header boxes

(patch -l -p 2 -i file.patch)

Make day label boxes into vboxes, and don't change their orientation.
Widen all-day header boxes.

Patch depends on bug 358688 to move widths to CSS.

Comment 2

[gekacheka]

Attachment: Image showing problem: wide day labels, narrow all-day events boxes

Comment 3

[gekacheka]

Attachment: Image after patch: narrower day labels, wider all-day events boxes

Comment 4

[gekacheka]

Comment on attachment 244061 [details] [diff] [review]
Patch: use vertical boxes for day labels, widen all-day header boxes

mvl, do you agree that when week view has horizontal times and vertical dates, arranging the dates to take less space, and providing more room to display all-day events, improves the UI?

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 244061 [details] [diff] [review]
Patch: use vertical boxes for day labels, widen all-day header boxes

ui-review=mvl

Comment 6

[Matthew (lilmatt) Willis]

Attachment: Screenshot after applying this patch

gekacheka:
This is what I get after applying this patch.  The date and day are not on top of each other like in your patch, therefore wasting space.  I'm assuming this is wrong, correct?

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 247865 [details]
Screenshot after applying this patch

(In reply to comment #6)
> Created an attachment (id=247865) [edit]

Ignore all of this. I was being a moron. I blame allergies.

Comment 8

[Matthew (lilmatt) Willis]

Comment on attachment 244061 [details] [diff] [review]
Patch: use vertical boxes for day labels, widen all-day header boxes

r=lilmatt now that I've got my head on straight.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 244061 [details] [diff] [review]
Patch: use vertical boxes for day labels, widen all-day header boxes

r2=mvl

Comment 10

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 11

[Martin Schröder [:mschroeder]]

VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre.