358891 - Firefox doesn't remember the search engine with non-ascii characters as its selected engine

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Kohei Yoshino [:kohei]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: N/A

The value of 'browser.search.selectedEngine' pref should be saved as complex value.
I'll make a patch.


Reproducible: Always

Steps to Reproduce:
1. Select new search engine with non-ascii characters from search bar.
2. Restart Firefox.

Actual Results:  
Selected search engine is now the default engine of Firefox.

Expected Results:  
Selected search engine is the engine i chose.

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: patch v1

This works for me.

Comment 2

[Kohei Yoshino [:kohei]]

We at Mozilla Japan request this fix for blocking1.8.1.1.

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: search engine with non-ascii characters

The search plugin of 楽天市場 (Rakuten shopping mall) that comes with ja locale.
You can test with it.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Thanks for the patch, and for finding my mistake :(. I landed this fix on the trunk, please verify.

mozilla/browser/components/search/nsSearchService.js 	1.88

Comment 5

[Kohei Yoshino [:kohei]]

Looks good on the trunk. Thank you!

Comment 6

[Jay Patel [:jay]]

Comment on attachment 244198 [details] [diff] [review]
patch v1

Approved for 1.8.1 branch, a=jay for drivers.  Please land asap.  Thanks!

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.72

Comment 8

[Jay Patel [:jay]]

Kohei:  Could you please verify this on the 1.8 branch as well?  Please test with  the latest -mozilla1.8 build and replace "fixed1.8.1.1" with "verified1.8.1.1" if the search engine selection works as expected.  Thanks!

Comment 9

[Kohei Yoshino [:kohei]]

Verified. Thanks!