359224 - Include nsTraceRefcnt.h in nsTArray.h

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Alex Menzies]

Compiling in xpcom results in the following error on my system:

xpcomcomponents_s.lib(nsStaticComponentLoader.obj) : error LNK2005: "protected: __thiscall nsTArray_base::nsTArray_base(void)" (??0nsTArray_base@@IAE@XZ) alread
y defined in nsTArray.obj
   Creating library xpcom_core.lib and object xpcom_core.exp
xpcom_core.dll : fatal error LNK1169: one or more multiply defined symbols found
make[2]: *** [xpcom_core.dll] Error 145

This error is resolved by including nsTraceRefcnt.h in nsTArray.h.

Comment 1

[Alex Menzies]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm...  I  guess the header does need the #define and the #define comes from nsTraceRefCnt.h....

I'm really not that happy including it here, but if there's no better way then we should, I guess.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, I don't see another way other than to move the define to another header.

Comment 4

[tor]

Checked in for Alex.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove pointless include

This should have gone in with the other patch, no?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in the .cpp patch.